GithubHelp home page GithubHelp logo

Comments (3)

jcoglan avatar jcoglan commented on August 21, 2024

This looks like it was fixed in #23 -- could you have a look at that thread and see if this is the same issue?

By the way, I'd appreciate you not calling things "crazy" when you find a bug in them :)

from canopy.

jcoglan avatar jcoglan commented on August 21, 2024

I'm closing this as fixed, per my above comment. While there are a lot of unchecked substring() calls in the generated code, the one that's really critical is the one generated by the chunk_() function, which allows a match to occur. All other substring() calls are used in TreeNode construction, which should only happen if the parser has succeeded up to the required string offset. It can only do this if leaf matchers like "hello", [world] or . have consumed input without overflowing the offset.

from canopy.

jcoglan avatar jcoglan commented on August 21, 2024

This should now be fixed as part of the v0.4 release; see https://blog.jcoglan.com/2022/04/01/announcing-canopy-0-4/

from canopy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.