Comments (6)
Makes sense, yeah I'll remove the requirement hopefully later today, ping me if I forget :P
from async-throttle.
Okay actually it seems that @babel/preset-env
still applies the regenerator transform for "targets": {"browsers": "last 2 versions"}
so I'm tempted to keep @babel/runtime
so that people don't have to go to the trouble of requiring regenerator-runtime/register
themselves.
Also, the reason you were seeing that error is not because Babel isn't used server-side, it's because the runtime transform was applied to the code but babel-register
is in devDependencies
, I forgot to put it in primary dependencies
.
Various other packages of mine have babel-register
in dependencies
which is why I wasn't getting this error myself.
So I'll upgrade to the latest @babel/runtime
and put it in dependencies
.
from async-throttle.
I guess another option is to use a conditional exports package and tell people to load the polyfills if necessary themselves...I dunno, what do you think?
from async-throttle.
🎉 This issue has been resolved in version 1.2.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
from async-throttle.
@jedwards1211 Awesome! Figured my PR was opinionated (don't use yarn for example...) but could be a reference. Appreciate the comments and thanks for pushing this out!
from async-throttle.
You're welcome!
from async-throttle.
Related Issues (9)
- Confusing example in readme HOT 1
- result.catch is not a function HOT 4
- Doesn't work, error async_throttle_1.throttle is not a function HOT 1
- Describe 'Other packages don't do it right.' HOT 6
- Exporting a `.d.ts` file? HOT 3
- Convert Project to TypeScript
- Add cancel/abort. HOT 4
- Calling .cancel results in UnhandledRejectionWarning HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from async-throttle.