ansible_processor _vcpus undifined on digital ocean FreeBSD box about ansible-role-nginx

[jdauphant]

It's looks like an Ansible bug.

You can define manually this variable to compensate : nginx_worker_processes

[mike-pt]

yeah thats what I did as a workaround, ans this was reported as a bug before ans supposedly fixed(I'll paste the ghi for reference later, on mobile now)

but in any case not an issue on you're side so I guess it can be closed

[mike-pt]

here:
ansible/ansible#9008

It seems the fix was reverted cause it was causing more issues, I wonder if this just affects FreeBSD or all DigitalOcean vms, If I have time I might take a peak at the code that gets this value, anyway for now I'll just edit the role and define the var to a default of "1" and increase in the playbooks if needed.

[Faheetah]

Came to this from the referenced issue, FYI the root cause isn't due to an Ansible bug, though the expected output may be. You're trying to use a variable that doesn't exist. Variables can be guarded using the default() filter, and given that facts might not be available it's probably best to do so. You could either default(1) or guard against it in the template. I'd use nginx_worker_processes: "{{ ansible_processor_vcpus|default(None) }}" then use {% if nginx_worker_processes %} block in the template.

[jdauphant]

@nowayride Ok thanks, don't hesitate to submit a PR

[mike-pt]

@nowayride that sounds 100% correct.

But I'd like to add that this fact should be present on FreeBSD, I was actually looking into the code a couple of days ago but then other stuff came up, the code is just doing it wrong for FreeBSD... its looking in dmesg for string that are not present / don't reflect the cpu/threads info, or maybe it was in older versions... anyway if I get some time tomorrow I'll poke around more... looking for "SMP" in dmesg would work.

I.E.

% dmesg | grep SMP
FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs
FreeBSD/SMP: 1 package(s) x 2 core(s) x 2 SMT threads

But anyway you're point is still pretty valid for any "fact"