Comments (6)
Took a look at the token management and the tokens in the tokens.jsonl file are never deleted.
They are deleted a week after they expire: https://github.com/jech/galene/blob/master/token/stateful.go#L372
(The reason they are not deleted earlier is that it is possible to extend a token after it has expired using /reinvite
.)
make a tokens.jsonl file for each group
That was my first design and I even started coding it, but it turned out to be too complicated, so I settled for the current design. We can always revisit this if there are clear advantages to the more complex approach.
Actually an admin from one group can see all tokens while he should just see the tokens from his own group.
It's not supposed to do that: https://github.com/jech/galene/blob/master/token/stateful.go#L329. Have you actually tried it, or are you just guessing?
using the token revoke function by /revoke user instead of /revoke link
Not a bad idea, but we usually use tokens with no username, so we haven't found the need for this feature. Additionally, you'd need to define what to do when there are multiple tokens for the same user. I'd be open to accepting a patch that adds a new command that does what you suggest.
supposing 1 is already implemented, delete the jsonl file an x amount of time/ after a meeting is finished
We already delete the file when all tokens have expired, see https://github.com/jech/galene/blob/master/token/stateful.go#L264.
from galene.
They are deleted a week after they expire: https://github.com/jech/galene/blob/master/token/stateful.go#L372
Maybe would be better to delete tokens as soon as there is no one in the meeting, let's say for 2 hours.
Obviously it's a bit more of work to detect if there are no users in the meeting.
It's not supposed to do that: https://github.com/jech/galene/blob/master/token/stateful.go#L329. Have you actually tried it, or are you just guessing?
my bad, sorry, working fine.
Not a bad idea, but we usually use tokens with no username, so we haven't found the need for this feature.
oh ok, got it. So you're generating tokens for anonymous users, they're not supposed to have a username but they can choose one if they want.
The approach we're using is generating directly a token + username, so they don't have to choose a name, which is a few clicks less; calling them "anonymous (anon)
" isn't the best thing.
Would be good if it's possible to delete tokens by username too (if any), faster to type and easier to remember.
from galene.
They are deleted a week after they expire: https://github.com/jech/galene/blob/master/token/stateful.go#L372
Maybe would be better to delete tokens as soon as there is no one in the meeting
Why would it be better?
Would be good if it's possible to delete tokens by username too
As I've said before, I think it's a good idea.
from galene.
Why would it be better?
because the file gets big if you have quite some meetings running each day and you're working only with tokens.
Waiting 7 days in order to get the tokens deleted is IMO too much.
I'm not using username/ password login, only using tokens login, easier and faster for users.
As for now i'm working with cUrl calls so all the json group files and the jsonl file stuff is automatized, based on a calendar where you can schedule conferences/ meetings. I have no idea how other galene users are managing files/ tokens, ecc. I think each one has it's own requirements and mostly people don't care how big a file gets.
from galene.
because the file gets big if you have quite some meetings running each day
How large is your tokens file? A token is less than 200 bytes, so I have trouble conceiving of a situation where the size of the tokens file is an issue.
from galene.
How large is your tokens file?
no idea about the actual size in kb, i just saw a huge list of tokens in the file itself so i tought it would be a good idea to delete them as soon as there's no one in the conference for x hours.
from galene.
Related Issues (20)
- any api available? HOT 6
- Websocket connection fails on Firefox HOT 3
- installing instructions not clear at all HOT 3
- display connection time in the UI HOT 5
- Would it be possible to use the github "releases" feature HOT 3
- WHIP authorization / authentication ? HOT 1
- Same user can login twice/ thrice/ ecc.. HOT 8
- Feature request: log ip + username when they join a room HOT 8
- /kick (anon) results in "Error: Unknown user (anon)" HOT 5
- feature request: mute a user in chat. (maybe /quiet /unquiet) HOT 4
- Feature request: ability remove specific messages from chat HOT 1
- best way to send the URL to another user for impromptu video conferences. HOT 3
- Feature request: Add UUID to username metadata of chat HOT 4
- example config and groups HOT 5
- Feature request: Optionally disable anonymous login HOT 9
- Feature request: Profiles & TEN OTHERs HOT 2
- Add a chat command for disabling screen sharing HOT 2
- Feature request (Accessibility): Optional Speech-to-Text (STT) integration HOT 3
- Geo links not parsed correctly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from galene.