GithubHelp home page GithubHelp logo

Comments (5)

jedisct1 avatar jedisct1 commented on August 24, 2024 1

Good point!

This will be useful if the binary gets a little bit bigger and more complex, but right now, it's just a small wrapper around the library that is unlikely to change much.

So, maybe we can wait for the next error handling crate :)

from rsign2.

tiziano88 avatar tiziano88 commented on August 24, 2024

Happy to look into this myself if there is interest in merging.

from rsign2.

jedisct1 avatar jedisct1 commented on August 24, 2024

Hi!

We don't have a lot of errors, and they are very simple.

So I rather not introduce a breaking change and an additional dependency with no real benefits.

from rsign2.

tiziano88 avatar tiziano88 commented on August 24, 2024

No problem, understandable. The downside of piling up on the minisign::* types for errors is that they don't necessarily make sense at application level. For instance, in my own PR, I had to create a PError and try to match its format instead of a more convenient type (e.g. anyhow::Result) that is more idiomatic for logging and preserves context. Anyway, your call of course, perhaps worth reconsidering later on.

Keep up the good work!

from rsign2.

tiziano88 avatar tiziano88 commented on August 24, 2024

Just in case it was not clear: I was suggesting this only for the binary crate of course, not for the library.

from rsign2.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.