GithubHelp home page GithubHelp logo

Comments (6)

JEG2 avatar JEG2 commented on June 25, 2024

Strange results in that you just want a normal String? I'm just making sure I understand.

from highline.

viking avatar viking commented on June 25, 2024

Yes, that, and the serialization does not appear to be reversible (which is the bigger problem):

require 'highline'
require 'yaml'

hl = HighLine.new
x = hl.ask("foo: ")
puts x.to_yaml
p YAML.load(x.to_yaml)

Output:

foo: bar
--- !ruby/string:HighLine::String |-
  YmFy
"YmFy"

from highline.

JEG2 avatar JEG2 commented on June 25, 2024

Yeah, we do need to fix this.

from highline.

mocoso avatar mocoso commented on June 25, 2024

This is a problem with YAML/Psych in ruby 2.0.0-p0 which does not handle subclasses of String correctly e.g.

require 'yaml'

class X < String
end

x =X.new('foo')
p YAML.load(x.to_yaml)

Output

"Zm9v"

from highline.

abinoam avatar abinoam commented on June 25, 2024

I couldn't reproduce the issue anymore. I think it was fixed in YAML. Added a test on 1c6a8fa to serve as guard against any future regression.

from highline.

JEG2 avatar JEG2 commented on June 25, 2024

Perfect.

from highline.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.