Remove dependency on WAN IP address about jellyfin-kodi

[oddstr13]

Does #28 solve this issue, or are you including cleaning up this mess and related code?

jellyfin-kodi/resources/lib/jellyfin/core/connection_manager.py

Lines 322 to 373 in c12918f

	def _test_next_connection_mode(self, tests, index, server, options):
	if index >= len(tests):
	LOG.info("Tested all connection modes. Failing server connection.")
	return self._resolve_failure()
	mode = tests[index]
	address = get_server_address(server, mode)
	enable_retry = False
	skip_test = False
	timeout = self.timeout
	LOG.info("testing connection mode %s with server %s", mode, server.get('Name'))
	if mode == CONNECTION_MODE['Local']:
	enable_retry = True
	timeout = 8
	if self._string_equals_ignore_case(address, server.get('ManualAddress')):
	LOG.info("skipping LocalAddress test because it is the same as ManualAddress")
	skip_test = True
	elif mode == CONNECTION_MODE['Manual']:
	if self._string_equals_ignore_case(address, server.get('LocalAddress')):
	enable_retry = True
	timeout = 8
	if skip_test or not address:
	LOG.info("skipping test at index: %s", index)
	return self._test_next_connection_mode(tests, index + 1, server, options)
	try:
	result = self._try_connect(address, timeout, options)
	except Exception:
	LOG.error("test failed for connection mode %s with server %s", mode, server.get('Name'))
	if enable_retry:
	# TODO: wake on lan and retry
	return self._test_next_connection_mode(tests, index + 1, server, options)
	else:
	return self._test_next_connection_mode(tests, index + 1, server, options)
	else:
	if self._compare_versions(self._get_min_server_version(), result['Version']) == 1:
	LOG.warn("minServerVersion requirement not met. Server version: %s", result['Version'])
	return {
	'State': CONNECTION_STATE['ServerUpdateNeeded'],
	'Servers': [server]
	}
	else:
	LOG.info("calling onSuccessfulConnection with connection mode %s with server %s", mode, server.get('Name'))
	return self._on_successful_connection(server, result, mode, options)

[mcarlton00]

I say merge 28 to get the auth fix out there, but for this one I was thinking of cleaning up all the related code around the mode checking and everything. We're not using that, so I'm of the opinion that it should be pulled out. Less unneeded code means it's more maintainable down the road. I'm planning on looking more deeply into it this weekend.

[dkanada]

@mcarlton00 I have a PR removing this in jellyfin-apiclient-javascript if that helps with the effort at all. It ended up only being a few hundred lines of code.

[mcarlton00]

#60 actually removed the dependency already. Ironically, the big crash was happening while trying to log the IP, it wasn't actually doing anything useful at the time.

I meant to update this ticket and forgot. There's just a lot of code hanging out about various connection types and logic for choosing which one to use that needs to get cleaned up still (Like oddstr's comment above). We should probably close this one and open a new ticket for that, though