GithubHelp home page GithubHelp logo

Comments (5)

Xaque8787 avatar Xaque8787 commented on July 18, 2024 1

Thanks for the quick response. I can confirm it works for both manual search and for scheduled tasks. Much appreciated!

from jellyfin-plugin-opensubtitles.

MBR-0001 avatar MBR-0001 commented on July 18, 2024

.strm files are not supported by the plugin, afaik even before the rewrite I did they weren't supported.

It seems that computing the hash of a .strm file (the actual remote file) might not be an easy task, so I believe the best course would be to just skip that part for .strm files and use the other data that is available.

from jellyfin-plugin-opensubtitles.

Xaque8787 avatar Xaque8787 commented on July 18, 2024

.strm files are not supported by the plugin, afaik even before the rewrite I did they weren't supported.

It seems that computing the hash of a .strm file (the actual remote file) might not be an easy task, so I believe the best course would be to just skip that part for .strm files and use the other data that is available.

Yeah it seems to be the case. The code doesn't seem to fallback to imdb I'd if the hash fails. I've fiddled around a bit and perhaps found a way to give a "dummy" hash (000000), in the hopes that then it will at least iterate to the part of the code that uses imdbid. I'm no dev or coder or anything so I'm a little stuck at building the edited plugin.

Any chance this will be addressed in the future? Would be as simple as instead of throwing an I/O error when hash failed to have some sort of fallback to imdbid?

Also would like to mention that sometime last year I believe, either in the late 10.7.x or early 10.8.x that plugin was successfully downloading subtitles from .strm. files. Sorry I can't recall the exact release, but I do know that one point in time it did work.

from jellyfin-plugin-opensubtitles.

MBR-0001 avatar MBR-0001 commented on July 18, 2024

I've created the pull request for this (#124) in which the code skips the hash for .strm files, I don't know when that will be merged and available, that is up to jellyfin maintainers

from jellyfin-plugin-opensubtitles.

MBR-0001 avatar MBR-0001 commented on July 18, 2024

You should be able to download a build from here https://github.com/MBR-0001/jellyfin-plugin-opensubtitles/actions/runs/5105670190 (artifacts), let me know how it works

from jellyfin-plugin-opensubtitles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.