Comments (5)
Thanks for the quick response. I can confirm it works for both manual search and for scheduled tasks. Much appreciated!
from jellyfin-plugin-opensubtitles.
.strm files are not supported by the plugin, afaik even before the rewrite I did they weren't supported.
It seems that computing the hash of a .strm file (the actual remote file) might not be an easy task, so I believe the best course would be to just skip that part for .strm files and use the other data that is available.
from jellyfin-plugin-opensubtitles.
.strm files are not supported by the plugin, afaik even before the rewrite I did they weren't supported.
It seems that computing the hash of a .strm file (the actual remote file) might not be an easy task, so I believe the best course would be to just skip that part for .strm files and use the other data that is available.
Yeah it seems to be the case. The code doesn't seem to fallback to imdb I'd if the hash fails. I've fiddled around a bit and perhaps found a way to give a "dummy" hash (000000), in the hopes that then it will at least iterate to the part of the code that uses imdbid. I'm no dev or coder or anything so I'm a little stuck at building the edited plugin.
Any chance this will be addressed in the future? Would be as simple as instead of throwing an I/O error when hash failed to have some sort of fallback to imdbid?
Also would like to mention that sometime last year I believe, either in the late 10.7.x or early 10.8.x that plugin was successfully downloading subtitles from .strm. files. Sorry I can't recall the exact release, but I do know that one point in time it did work.
from jellyfin-plugin-opensubtitles.
I've created the pull request for this (#124) in which the code skips the hash for .strm files, I don't know when that will be merged and available, that is up to jellyfin maintainers
from jellyfin-plugin-opensubtitles.
You should be able to download a build from here https://github.com/MBR-0001/jellyfin-plugin-opensubtitles/actions/runs/5105670190 (artifacts), let me know how it works
from jellyfin-plugin-opensubtitles.
Related Issues (20)
- For a specific TV show, plugin can search but not download in 12.0.0, and not search at all in 18.0.0 HOT 4
- [Request] Add Chinese Bilingual as an option HOT 1
- Subtitles aren't downloaded automatically for me. HOT 20
- [Issue]: OpenSubtitles.com Username and/or Password NOT working. HOT 14
- Can't sign in HOT 10
- OpenSubs API Key ServiceUnavailable HOT 1
- API rate limit exceeded HOT 3
- Service Unavailable Error HOT 2
- Open Subtitles 18.0.0.0.0 - Status: Malfunctioned HOT 2
- [Issue]: Subtitles added to queue but are not downloaded HOT 5
- Can't save authentication credentials HOT 2
- Subtitle download fails HOT 2
- [opensubtitles] Contact us HOT 3
- [Issue]: ServiceUnavailable error when download subtitles HOT 2
- Unable to sign into the opensubtitles plugin HOT 11
- Can't download subtitles HOT 1
- Refresh the view when a subtitle track has finished downloading HOT 2
- Can't Sign in to plugin: Request failed - BadGateway HOT 1
- 502 bad gateway error HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jellyfin-plugin-opensubtitles.