TvShow missing data about tmdblib

[LordMike]

Could you post some example code?
For example,
Client.GetTvShow(1396); // breaking bad

... Doesn't give all nulls.

[rboy1]

TvShow show = client.GetTvShow(2734);

There are 16 season objects returned full of nulls. But I use client.GetTvSeason and cycle through each season I get the correct information back. Same for episodes

[LordMike]

I see what you mean now.
That information isn't disclosed by TMDb via that API call, but we share the object with GetTvSeason(). So you'll see nulls when you go through GetTvShow().

So unfortunately, it's expected behaviour, as I don't recall there being an option to change this / request all seasons immediately. I'll make a ticket, however, to split the object in two so that others don't get confused. Thanks for reporting :)

[rboy1]

I didn't understand what you mean by splitting the object into two.
How about TMDBLib internally calling GetTVSeason and GetTvEspisides in a loop to get all the season and spisodes objects and populate them when GetTvShow is called. (it's the end objective that matter and that also makes coding easier from a dev's perspective, took me hours to get thw whole thing working and understand why it wasn't in the firts palce)

[LordMike]

I'd like to keep the library to one-method for one-apicall.

Although I agree that you shouldn't have gotten the impression that you could've gotten some information, which you didn't get. The consequences of doing what you suggest could be another series of very hard to track bugs, where users end up exhausting their quota. That, or we'd add it as an option, autoFetchSeasons = true|false, and then we'd have more maintenance / a documentation problem telling users they missed that option.

If you just want the seasons. You could always do:

List<TvSeason> seasons = client.GetTvShow(2734).Seasons.Select(s => client.GetTvSeason(2734, s.SeasonNumber)).ToList();

Or in parallel:

List<TvSeason> seasons = client.GetTvShow(2734).Seasons.AsParallel().Select(s => client.GetTvSeason(2734, s.SeasonNumber)).ToList();

[rboy1]

Won't that cause a timeout doing in parallel due to rate limitation?
I love the optional flag idea

On Apr 19, 2014, at 11:17 AM, Michael Bisbjerg [email protected] wrote:

I'd like to keep the library to one-method for one-apicall.

Although I agree that you shouldn't have gotten the impression that you could've gotten some information, which you didn't get. The consequences of doing what you suggest could be another series of very hard to track bugs, where users end up exhausting their quota. That, or we'd add it as an option, autoFetchSeasons = true|false, and then we'd have more maintenance / a documentation problem telling users they missed that option.

If you just want the seasons. You could always do:

List seasons = client.GetTvShow(2734).Seasons.Select(s => client.GetTvSeason(2734, s.SeasonNumber)).ToList();
Or in parallel:

List seasons = client.GetTvShow(2734).Seasons.AsParallel().Select(s => client.GetTvSeason(2734, s.SeasonNumber)).ToList();
—
Reply to this email directly or view it on GitHub.