GithubHelp home page GithubHelp logo

Allow to add a `skip-updatecli` label on pull requests to avoid failing builds when introducing new files about pipeline-library HOT 5 CLOSED

jenkins-infra avatar jenkins-infra commented on May 31, 2024
Allow to add a `skip-updatecli` label on pull requests to avoid failing builds when introducing new files

from pipeline-library.

Comments (5)

dduportal avatar dduportal commented on May 31, 2024

🤔 It's not clear what is the goal? Why would you want to add a new updatecli manifest file if you don't want to check that it work by running it?

(besides, why on pipeline-library?)

from pipeline-library.

lemeurherve avatar lemeurherve commented on May 31, 2024

It's not clear what is the goal? Why would you want to add a new updatecli manifest file if you don't want to check that it work by running it?

I'd like to be able to skip updatecli when introducing new file not present on the main branches and failing the builds if concerned by an updatecli manifest.

Ex: jenkins-infra/kubernetes-management#3487 > https://infra.ci.jenkins.io/blue/organizations/jenkins/updatecli%2Fkubernetes-management/detail/PR-3487/1/pipeline

This label would allow us to get a "green" build in these cases.

why on pipeline-library?

Because it should be a relatively easy and centralised location for @jenkins-infra, something like #552

from pipeline-library.

dduportal avatar dduportal commented on May 31, 2024

Ex: jenkins-infra/kubernetes-management#3487 > https://infra.ci.jenkins.io/blue/organizations/jenkins/updatecli%2Fkubernetes-management/detail/PR-3487/1/pipeline

This label would allow us to get a "green" build in these cases.

I'm not sure to understand: this build is green, and the PR is not blocked at all (the "required" on checks is on a green build). it's only the "updatecli" stage that is failing.

from pipeline-library.

lemeurherve avatar lemeurherve commented on May 31, 2024

it's only the "updatecli" stage that is failing.

Indeed, but looking at the PR on GitHub it's failed:
image

I know it's not that important (for us with our permissions at least), but I think it could be nice to have and harmless nevertheless.

from pipeline-library.

dduportal avatar dduportal commented on May 31, 2024

it's only the "updatecli" stage that is failing.

Indeed, but looking at the PR on GitHub it's failed: image

I know it's not that important (for us with our permissions at least), but I think it could be nice to have and harmless nevertheless.

I prefer explicit errors to have a "mark" saying "this PR did not meet the expected behavior" (which updatecli is).

from pipeline-library.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.