GithubHelp home page GithubHelp logo

Comments (3)

cdelmonte-zg avatar cdelmonte-zg commented on June 3, 2024 1

Hi @grantsunny
added in the release 1.6.3
Thanks!

from bitbucket-push-and-pull-request-plugin.

macghriogair avatar macghriogair commented on June 3, 2024

Hello @grantsunny ,
thank you for your review and comment! I think, indeed the pattern matching is done wrong way around here and was introduced with #18
Reading through the BranchSpec source, it should instead be instantiated with the parts of allowedBranches, as you propose. Feel free to provide a PR! :)

from bitbucket-push-and-pull-request-plugin.

grantsunny avatar grantsunny commented on June 3, 2024

Hi @cdelmonte-zg and @macghriogair

I were very happy for this change so I downloaded this upgrade but it seems my build is not being triggered. After checking the content of the commit I found this PR seems just for Bitbucket Cloud, but may forget to make changes for Bitbucket server which is supposed to be taken care of in BitBucketPPRServerRepositoryPushActionFilter?

Anyway, thank you so much for your attention and appreciate your great help!
Regards,
Grant.

from bitbucket-push-and-pull-request-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.