[JENKINS-9376] NPE when validating form if configuration contains international characters about publish-over-ssh-plugin

[jira-importer]

turb:

Note: in fact, this bug is more strange than I thought.

I have no error only if :
1) I try to add an ssh publishing to an existing build (NPE)
2) Save
3) Go back to configuration => here is my publish over ssh configuration panel

[jira-importer]

bap:

Have you configured any SSH Servers in the main configuration page (Manage Jenkins > Configure System)?

Could someone have changed the name of the Configuration whilst the Job configuration page was alresdy open?

The line in question is only called from the form validation when configuring a job, and is passed the value of the configuration name that is in the drop down list. The list is generated from the configurations defined in the main configuration. The only way that getConfiguration can return null is if configName is null, or if configName does not match the name of any of the configurations that exist when the call is made.

Where did you see this error - was it in red in the validation area? (where you see "Required", etc.)

I will make the check more robust by returning a validation message like "no such configuration - check System Configuration" if either configName is null, or if a configuration could not be located, but it would be useful to find out what the issue is in your case.

[jira-importer]

bap:

Sylvain,

Can you also let me know which browser/browser version and OS you were using?

Thanks,
Bap.

[jira-importer]

turb:

OK, trying to make some tests to answer your different questions, I think I found the problem.

First of all, note it occured paired with JENKINS-9175 - sorry to have forgotten to mention this.

It is in fact the same problem. It occurs if:

• there is no SSH configuration yet (I didn't tested it again yet) OR
• the SSH configuration has some non-ascii chars in its name (so in the same fashion as JENKINS-9175 )

I think that promoted-builds JENKINS-9175 has also a direct influence on it.

My client conf:

• 32b Windows Vista SP2
• Firefox 3.6.16

See attached a capture with the stacktrace (note the non-ascii char "é" that made me test this point).

Could someone have changed the name of the Configuration whilst the Job configuration page was alresdy open?

No.

(I think I answered all questions)

[jira-importer]

bap:

Thank you for your help.
I guess that the rest of the options (Remove prefix, Remote directory, etc) appeared below the stack trace.

Can you try the 0.10 release of Publish Over SSH Plugin?

This will not give an NPE, but I'd like to know what you get in the source files validation area before you enter anything.

Also can you let me know if there are any errors in the javascript error console? (Firefox > Tools > Error Console)
Can you clear the console, then re open the page - I'm sure there will be errors, but I'd like too see if there are any from my plugin.

Finally can you send me a copy of your jenkins.plugins.publish_over_ssh.BapSshPublisherPlugin.xml configuration file from $JENKINS_HOME?
Make sure you * out any passwords and keys first (host information as well if you want)! - they are encrypted, but delete them anyway.

I'm away for the weekend, so I'll investigate further on Monday.

Thanks agian.

[jira-importer]

bap:

Pls send the (zipped up) config file to bap-jenkins at BapIT dot co dot uk

[jira-importer]

turb:

I installed 0.10

As you said, there is no more NPE, but one error:

"Could not find the SSH Server configuration named [Int�gration Argos]- check the System Configuration and then reload this configuration page" (see capture 2)

If if throw away the non-ascii char, there is no error.

—

There is no error in the Firefox console; only warnings, but in French:

"Avertissement : La propriété « charCode » d'un événement « keyup » ne doit pas être utilisée. Cette valeur n'a pas de sens.
Fichier Source : https://issues.jenkins-ci.org/browse/JENKINS-9376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=147862#comment-147862
Ligne : 0"

That can be translated as: "Warning: "charCode" property of a "keyup" event should not be used. This value makes no sense".

There is no other warnings (but this one again and again).

I send you my jenkins.plugins.publish_over_ssh.BapSshPublisherPlugin.xml soon.

Thank you for this quick reaction!

[jira-importer]

scm_issue_link:

Code changed in jenkins
User: bap2000
Path:
src/main/webapp/js/pos.js
http://jenkins-ci.org/commit/publish-over-ssh-plugin/debc24f899188fd247e14aec7d4b915eebc0f7ac
Log:
[FIXED JENKINS-9376] ajax form validation with international characters in configuration name

[jira-importer]

bap:

Fixed in 0.11

[jira-importer]

bap:

Thank you so much!

Try 0.11 I think you will find it is fixed.
Can you report back so I can close the issue - or if it is not fixed then I will have another look.

The problem was only with the form validation, the plugin would have worked when run - it was just that it didn't look like it

[jira-importer]

turb:

Solved in 0.11 (checked).

Thank you very much!