Incorrect trigger error when using of with multiple events about hair_trigger

[hovsater]

@jenseng I'll take a look at this and see if I can submit a PR by the end of the week. 🙂

[jenseng]

Thanks for the bug report @KevinSjoberg 👍

Yeah, the assumption right now in the code is that all parts of the chain apply to the generated trigger(s), so it tries to apply the of to the insert trigger, which is not valid. Seems like to support this we'd need to change this check to something like:

... if options[:of] && !(options[:events] || []).include?("UPDATE")

and also rework this generate_trigger_postgresql logic, since it just blindly puts the OF clause after the events. I'd happily accept a pull request w/ a couple specs around it.

In the meantime, you could do something like this as a workaround:

trigger_sql = <<-SQL
  -- If row is current, do nothing.
  IF (TG_OP = 'UPDATE' AND OLD.current = true) THEN
    RETURN NEW;
  END IF;

  -- Ensure user roles are not marked as current
  UPDATE roles SET current = null WHERE current = true AND user_id = NEW.user_id;

  RETURN NEW;
SQL
trigger.before(:insert).where('NEW.current') { trigger_sql }
trigger.before(:update).of(:current).where('NEW.current') { trigger_sql }

[hovsater]

@jenseng is this still an issue? I'm doing a bit of issue cleanup on my part.

[jenseng]

Hi @KevinSjoberg, I believe so, I haven't done anything with it yet. So I'll leave this issue open in case anyone else wants to take a stab at it.

I like to think I'll get to it eventually, but the reality is I write very little ruby these days and haven't used this gem in a project in years 😢

[hovsater]

@jenseng same here. I'll close it and let it resurface if needed.