N+1 happening after PR #171 about laravel-roles

[denydias]

Well, after some extensive investigation, I could not find what's causing lots of N+1 when using Traits\HasRoleAndPermission->getRoles() after PR #171. For now I'll just accept the fact my code skills are rust or my knowledge is not up to a better solution (or both).

As a workaround, I'm now just overriding getRoles() in the user model like this...

namespace App\Models;

use Illuminate\Database\Eloquent\Collection;
use Illuminate\Foundation\Auth\User as Authenticatable;
use jeremykenedy\LaravelRoles\Traits\HasRoleAndPermission;

class User extends Authenticatable
{
    use HasRoleAndPermission;
    ...
    /**
     * Overrides jeremykenedy\LaravelRoles\Traits\HasRoleAndPermission->getRoles()
     * to avoid N+1 introduced by PR #171.
     *
     * @see https://github.com/jeremykenedy/laravel-roles/issues/179
     * @see https://github.com/jeremykenedy/laravel-roles/pull/171
     *
     * @return Collection|null
     */
    public function getRoles(): ?Collection
    {
        return ! $this->roles ? $this->roles = $this->roles()->get() : $this->roles;
    }
}

...then N+1 are gone. That WFM now.

As I couldn't find the root causes in the package or in my code, I'll just leave this issue opened so others may have a reference and maybe provide a better solution.

[jeremykenedy]

I believe this was solved in a recent update. If it occurs again please let me know and I will re-open the issue. Thank you