GithubHelp home page GithubHelp logo

Comments (6)

DellanX avatar DellanX commented on June 9, 2024 1

I think the feature is pretty easy to add and will give it a shot over the next few days. I've never worked with commands before, so it may take a bit of tinkering.

from laravel-packager.

Jeroen-G avatar Jeroen-G commented on June 9, 2024

I'm not really working on this package at the moment but your idea sounds nice and could maybe be a flag to pass with the existing git command. If you're able to create a PR I'd be happy to review it!

from laravel-packager.

dave-mills avatar dave-mills commented on June 9, 2024

@DellanX your post is perfect timing for me! I'm also working on a setup to let us develop multiple packages with a lot of front-end assets, and was starting down the route of submodules...

If you're going to work on a PR for this, great! If not, I'll try and put something together next week as I'd like to use this package along with a submodule setup.

from laravel-packager.

DellanX avatar DellanX commented on June 9, 2024

Okay, created a fork, and implemented a change.
There was already a few speed bumps I'll need to solve:

  1. Path format. Right now the submodule path is absolute (/var/www/html/packages/vendor/package).
    while everyone on my side uses sail, I could see this becoming an issue for a non-sail developer.
    I'm adding an optional config setting to allow defining the packages directory.
  2. Removing a package.
    The directory can't just be deleted, it'll need to identify that a submodule is present, and run git rm <path>

from laravel-packager.

dave-mills avatar dave-mills commented on June 9, 2024

I'm adding an optional config setting to allow defining the packages directory.

As a non-sail dev, thank you! :)

from laravel-packager.

DellanX avatar DellanX commented on June 9, 2024

As a heads up, I stopped working on this a bit ago. But I can drop what I discovered here:

  1. The change to add support for git submodule was pretty easy, you can look at my repo here: https://github.com/DellanX/laravel-packager
  2. The difficulties with this functionality are making sure that the submodule is tracked correctly, as the conveyer isn't really compatible.

To handle naming the submodule correctly, the easiest way to publish the packager config file, and set the path to 'packages'
Perhaps a function can later be added to conveyor to get the entire path relative to the project directory.

To handle removing packages... never really got there. You'll likely need to execute git rm somewhere in the Remove Command. (I added it a few times, but it struggled. Perhaps the force flag is required)

from laravel-packager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.