Comments (6)
I think the feature is pretty easy to add and will give it a shot over the next few days. I've never worked with commands before, so it may take a bit of tinkering.
from laravel-packager.
I'm not really working on this package at the moment but your idea sounds nice and could maybe be a flag to pass with the existing git command. If you're able to create a PR I'd be happy to review it!
from laravel-packager.
@DellanX your post is perfect timing for me! I'm also working on a setup to let us develop multiple packages with a lot of front-end assets, and was starting down the route of submodules...
If you're going to work on a PR for this, great! If not, I'll try and put something together next week as I'd like to use this package along with a submodule setup.
from laravel-packager.
Okay, created a fork, and implemented a change.
There was already a few speed bumps I'll need to solve:
- Path format. Right now the submodule path is absolute (/var/www/html/packages/vendor/package).
while everyone on my side uses sail, I could see this becoming an issue for a non-sail developer.
I'm adding an optional config setting to allow defining the packages directory. - Removing a package.
The directory can't just be deleted, it'll need to identify that a submodule is present, and rungit rm <path>
from laravel-packager.
I'm adding an optional config setting to allow defining the packages directory.
As a non-sail dev, thank you! :)
from laravel-packager.
As a heads up, I stopped working on this a bit ago. But I can drop what I discovered here:
- The change to add support for git submodule was pretty easy, you can look at my repo here: https://github.com/DellanX/laravel-packager
- The difficulties with this functionality are making sure that the submodule is tracked correctly, as the conveyer isn't really compatible.
To handle naming the submodule correctly, the easiest way to publish the packager config file, and set the path to 'packages'
Perhaps a function can later be added to conveyor to get the entire path relative to the project directory.
To handle removing packages... never really got there. You'll likely need to execute git rm somewhere in the Remove Command. (I added it a few times, but it struggled. Perhaps the force flag is required)
from laravel-packager.
Related Issues (20)
- git commit all files after `packager:new` by default, with option to skip? HOT 4
- [Proposal] Also provide kebab-case vendor name and package name when replacing HOT 3
- Keywords not replaced HOT 2
- Add at least one model, one migration and one seeder HOT 1
- php 8 support HOT 2
- Interface 'Illuminate\Contracts\Validation\Rule' not found HOT 1
- cURL error 60: SSL certificate problem: unable to get local issuer certificate HOT 1
- All Packages Getting Deleted! HOT 1
- v2.7.2 composer.json does not support PHP 8.0
- Problem when run packages with laravel 9.0 HOT 1
- Adding additional dependencies HOT 1
- Non-static method Rabol\Testpackage\Testpackage::test() cannot be called statically HOT 1
- artisan packager:get fail
- Problem when run packages with laravel 10 HOT 2
- `tests` folder does not appear HOT 2
- copy from the github page does not work HOT 1
- Allow publish to use main instead of master HOT 1
- Windows composer.json problem HOT 1
- Problem with Laravel 11 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from laravel-packager.