How to control spaces between tags about slang

[jeromegn]

That's currently not implemented, the equivalent from slim would be: http://www.rubydoc.info/gems/slim/frames#Trailing_and_leading_whitespace_______

Something like:

    a href="#"
      span
      > Contacts

[infernalmaster]

Looks like slim trims all whitespaces between tags by default. So >, <, ' for adding spaces not for deleting:

You can force Slim to add a trailing whitespace after a tag by adding a >.
You can add a leading whitespace by adding <.

The single quote tells Slim to copy the line (similar to |), but makes sure that a single trailing white space is appended.

So looks like that it's HAML removes spaces with that characters http://haml.info/docs/yardoc/file.REFERENCE.html#whitespace-removal--and-

I have time and need to help you with that but we should decide what we should to do with this

[jeromegn]

IIRC it’s either a rails thing or slim thing in production where it compresses the HTML as much as possible. Could be a setting with the parser.

…

On November 24, 2017 at 7:22:08 PM, Rostyslav Diachok ( ***@***.***) wrote: Looks like slim trims all whitespaces between tags by default. So >, <, ' for adding spaces not for deleting: You can force Slim to add a trailing whitespace after a tag by adding a >. You can add a leading whitespace by adding <. The single quote tells Slim to copy the line (similar to |), but makes sure that a single trailing white space is appended. So looks like that it's HAML removes spaces with that characters http://haml.info/docs/yardoc/file.REFERENCE.html#whitespace-removal--and- I have time and need to help you with that but we should decide what we should to do with this — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#29 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACpPW5kvpTAMqQyF7GJrfwO_0MdCXRIks5s512wgaJpZM4QpPpM> .

[infernalmaster]

I found good workaround. I'm using ECR partials for that critical places.

[mig-hub]

Trimming all whitespace by default would be great.
It is also better for inline-block elements.

[robacarp]

Indeed, Slim does trim all whitespace by default. Haml injects it by default, like slang does, but haml also provides a way to prevent it from being added.

[robacarp]

I think this is a more obvious example. <span> tags are display: inline, so spacing around them matters more than around most html elements.

| un
span.red forget
| able

which renders

un
<span class="red">forget</span>
able

and therefore the rendered html looks like un forget able.

The only way I've been able to get around this extra spacing is:

    == %(un<span class="red">forget</span>able)

[jeromegn]

I agree. I've had this problem before with inline elements with slim.

I'm wondering what's the best way to do this. Basically trim all whitespace everywhere between "nodes" (text and elements)? Unless text uses ' (iirc, we don't support < or > yet.)

There are exceptions like special blocks for javascript or css.

[donovanglover]

How about using parentheses (or something similar) for inline Slang instead?

Input:

p Slang is a (span.color (em Slim)-inspired) templating language.

Output:

<p>Slang is a <span class="color"><em>Slim</em>-inspired</span> templating language.</p>

[robacarp]

@jeromegn it's hard to say for sure, but given that HTML is mostly ignorant of whitespace, it might be a safe first pass to just trim all whitespace. It would solve this problem, but I suspect it'd generate other problems.

Adding support for > and other whitespace manipulation, if possible, is probably a smart choice before making such a big change to the output every slang file generates. That would also bring Slang into closer parity with Slang, right?

[rperce]

@infernalmaster why did you close this? It seems like this is still a problem.

FWIW, since this is mostly a problem with spans, for a personal workaround I've committed the cardinal sin of Parsing HTML With Regex and

private macro view(filename, title argtitle = nil)
    title = {{argtitle}} || "{{filename.id}}"
    render("src/views/{{filename.id}}.slang", "src/views/Layout.slang")
        .gsub(/(<span[^>]*>)\n\s*/, "\\1") # newline after opening span
        .gsub(/<\/span>\n\s*<span/, "</span><span") # newline between spans
        .gsub(/\n\s*(<\/span>)/, "\\1") # newline before closing span
end

If there's a better way - if this has been solved properly and I just haven't noticed, or if I should be approaching the problem different, etc - I'd love to know!

[robacarp]

The reason this is more obvious with spans is that spans aren't block level elements. Added spacing into/around a block element is often not noticeable because it doesn't change flow in the document. For inline elements like span, link, strong, em, etc, the extra space matters more. For example, <strong>this</strong>text will show up as thistext (no space) whereas <div>this</div>text will show up with a newline because the vanilla div styling forces it.

[infernalmaster]

Hey @rperce Apologies for the confusion, I closed it because I didn't see any activity in this thread for a long time, so I thought maybe it was fixed or no one cares

[rperce]

@robacarp yeah, totally understand why it's more relevant for spans, just wanted to share my workaround for anyone else running into this.

@infernalmaster reasonable! Thanks for the re-open - I would love to see this revisited.

[jeromegn]

Chiming in here: I don't think this is a huge change.

I've been out of touch with Crystal, so I'd rather somebody else contribute a PR :)

I do think this is a useful feature!

[infernalmaster]

I did my best, but there are some limitations with embedded JS code. Some of problems present in inside master branch.