GithubHelp home page GithubHelp logo

Comments (9)

Soenhay avatar Soenhay commented on August 23, 2024

This link appears to be related:

https://arstechnica.com/civis/viewtopic.php?t=185317

from url-search-params-polyfill.

Soenhay avatar Soenhay commented on August 23, 2024

Changing
prototype.delete
to
prototype['delete']

And changing
this.delete (keys[i]);
to
this['delete'](keys[i]);

Removes the error but further testing is needed to see if it is an actual fix.

from url-search-params-polyfill.

jerrybendy avatar jerrybendy commented on August 23, 2024

I just tested on my IE 11.1480.14393.0, and everything worked well. The link you gave me is about IE and extending HTML elements.

Although delete is a key word in javascript, but using delete as an object's property is allowed.

Such as:

// They are allowed 
var Obj = function() {}
Obj.delete = function() {}
Obj.prototype.delete = function() {}

from url-search-params-polyfill.

Herst avatar Herst commented on August 23, 2024

According to http://kangax.github.io/compat-table/es5/#test-Object/array_literal_extensions_Reserved_words_as_property_names IE11 ought to support reserved keywords as properties quite well. This is not the case for IE8, are you sure you weren't in the IE8 rendering mode @Soenhay?

from url-search-params-polyfill.

Soenhay avatar Soenhay commented on August 23, 2024

"Display Intranet Sites in Compatibiliy View" was checked but I am not currently able to reproduce the issue so checking or unchecking it does not appear to change anything.

Changing it to "this['delete']" was not really any use either since calling delete would not work.

I just realized that it is still not working.

from url-search-params-polyfill.

Soenhay avatar Soenhay commented on August 23, 2024

It is actually still not working. I was testing with the modified file earlier.

Also, I am loading the page that calls the library into an iFrame.

from url-search-params-polyfill.

Soenhay avatar Soenhay commented on August 23, 2024

In relation to this link: https://docs.microsoft.com/en-us/internet-explorer/ie11-deploy-guide/fix-compat-issues-with-doc-modes-and-enterprise-mode-site-list

The default document mode on my page in IE11 is 5. If I change it to 8,9 or 10 in the emulation tab then the "Expected identifier" error in index.js goes away and a new error in an unrelated script occurs. So unless I am mistaken it would appear that it is running in an older rendering mode as Herst suggested.

Closing again.

from url-search-params-polyfill.

Herst avatar Herst commented on August 23, 2024

IE5?! Were you missing a proper DOCTYPE?

from url-search-params-polyfill.

Soenhay avatar Soenhay commented on August 23, 2024

It is a legacy website :) where I can not change the DOCTYPE. Our custom page is in an iFrame and I found that I do not really need the library on that particular site so I am no longer trying to load it there. I am using it for some older versions of Safari on iPads and iPhones and it is working great.

from url-search-params-polyfill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.