Selective run about branch-cleanup-action

[sburns]

I've been messing around w/ this too. I tried to add a filter action like

action "pull request is closed" {
  uses = "actions/bin/filter@master"
  args = "action closed"
}

action "delete closed PR" {
  uses = "jessfrazz/merge-branch-cleanup@master"
  needs = "pull request is closed"
  secrets = ["GITHUB_TOKEN"]
}

but in practice, this doesn't work because the "pull request is closed" action will return neutral status, thereby canceling the "delete closed PR" action. This cancelation is marked as a negative/red check on the PR, and if you have controls that only allow fully-passing PRs to be merged, this PR now can't be merged. This check is done within the script in this repo here.

From what I know about Actions right now, it seems like this needs to run on every pull-request event.

[jessfraz]

They are working on changes with exit codes to make it cleaner when you use something like a filter so it’s not red.

But all support for actions and requests like that need to go to support@ not this repo sorry.

[jessfraz]

Oh it’s definitely being worked on :)

On Tue, Dec 11, 2018 at 22:55 Scott Burns ***@***.***> wrote: Can you internally bump some of those emails? Feels like sending to /dev/null right now :) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABYNbGvfM8vugyoCFpN3DIZz5VS8kGVvks5u4H4xgaJpZM4ZKRuk> .

-- Jessie Frazelle 4096R / D4C4 DD60 0D66 F65A 8EFC 511E 18F3 685C 0022 BFF3 pgp.mit.edu <http://pgp.mit.edu/pks/lookup?op=get&search=0x18F3685C0022BFF3>

[distantcam]

I've had similar thoughts about how to define different "filters" to trigger the branch cleanup.

I ended up copying some of this repo into my own here - https://github.com/distantcam/github-actions

I took this action, removed the conditionals, and then used filter actions to replace those conditionals. The result works, but it looks ugly and confusing in the UI right now.

[sburns]

Can you internally bump some of those emails? Feels like sending to /dev/null right now :)