Problem during smali of Froyo odexes about smali

[JesusFreke]

Comment #1 originally posted by JesusFreke on 2010-06-09T13:17:47.000Z:

Can you provide a snippet of the smali code around one of the lines that it is complaining about?

[JesusFreke]

Comment #2 originally posted by JesusFreke on 2010-06-09T13:28:13.000Z:

Line 396 in AddBookmarkPage.smali: invoke-virtual {v16 .. v16}, Ljava/lang/String;->length()I
Line 5673 in BrowserActivity.smali: invoke-virtual {v16 .. v16}, Ljava/lang/String;->length()I
Line 856 in BrowserProvider,smali: invoke-virtual {p2 .. p2}, Ljava/lang/String;->length()I

[JesusFreke]

Comment #3 originally posted by JesusFreke on 2010-06-09T13:29:31.000Z:

Line 396 in AddBookmarkPage.smali: invoke-virtual {v16 .. v16}, Ljava/lang/String;->length()I
Line 5673 in BrowserActivity.smali: invoke-virtual {v16 .. v16}, Ljava/lang/String;->length()I
Line 856 in BrowserProvider,smali: invoke-virtual {p2 .. p2}, Ljava/lang/String;->length()I

[JesusFreke]

Comment #4 originally posted by JesusFreke on 2010-06-09T13:35:09.000Z:

Can you provide some context to one of those? I'd like to see the code around one of those locations as well

[JesusFreke]

Comment #5 originally posted by JesusFreke on 2010-06-09T13:42:43.000Z:

From AddBookmarkPage.smali:

.line 179
.local v6, emptyTitle:Z
:goto_31
invoke-virtual {v13}, Ljava/lang/String;->trim()Ljava/lang/String;

move-result-object v16

invoke-virtual {v16 .. v16}, Ljava/lang/String;->length()I

move-result v16

if-nez v16, :cond_79

const/16 v16, 0x1

move/from16 v7, v16

from BrowserActivity.smali:

.line 363
.local v10, jsFlags:Ljava/lang/String;
invoke-virtual {v10}, Ljava/lang/String;->trim()Ljava/lang/String;

move-result-object v16

invoke-virtual {v16 .. v16}, Ljava/lang/String;->length()I

move-result v16

if-eqz v16, :cond_28b

.line 364
move-object/from16 v0, p0

iget-object v0, v0, Lcom/android/browser/BrowserActivity;->mTabControl:Lcom/android/browser/TabControl;

move-object/from16 v16, v0

invoke-virtual/range {v16 .. v16}, Lcom/android/browser/TabControl;->getCurrentWebView()Landroid/webkit/WebView;

move-result-object v16

[JesusFreke]

Comment #6 originally posted by JesusFreke on 2010-06-09T13:45:06.000Z:

Gotcha, thanks. It's using the /range style of registers for a non-range invoke. weird. I'll look into it, thanks

[JesusFreke]

Comment #7 originally posted by JesusFreke on 2010-06-09T13:48:03.000Z:

Excellent, thanks. :-)

[JesusFreke]

Comment #8 originally posted by JesusFreke on 2010-06-09T15:29:17.000Z:

Yeah, I noticed this problem too. Sometimes there are normal (not range) invokes for a range of registers, also there are e.g. {v1 .. v2} or even {v1 .. v1} invokes everywhere.

[JesusFreke]

Comment #9 originally posted by JesusFreke on 2010-06-10T01:44:18.000Z:

Fixed :)

http://code.google.com/p/smali/source/detail?r=731