baksmali doesn't handle certain cases with try/catch blocks correctly when deodexing unresolvable instructions. about smali

[JesusFreke]

Comment #1 originally posted by JesusFreke on 2010-06-10T14:36:06.000Z:

Some additional discussion of this is in the comments on issue 29: http://code.google.com/p/smali/issues/detail?id=29

[JesusFreke]

Comment #2 originally posted by JesusFreke on 2010-06-10T14:38:03.000Z:

Keep up the great work JF! :-)

P

[JesusFreke]

Comment #3 originally posted by JesusFreke on 2010-06-11T05:38:58.000Z:

I've committed some experimental changes which should better handle cases like these. Please grab a copy of the ExperimentalDeodexChange branch and try it out, and let me know how it works for you :)

svn checkout http://smali.googlecode.com/svn/branches/ExperimentalDeodexChange smali

[JesusFreke]

Comment #4 originally posted by JesusFreke on 2010-06-11T12:54:37.000Z:

So far so good... :-)

[JesusFreke]

Comment #5 originally posted by JesusFreke on 2010-06-11T13:20:25.000Z:

Great! :)

I had an epiphany last night, which led to this implementation. Before, I was commenting out the dead code after a deodexeable instruction, because there were some cases where that following code wouldn't pass dalvik's validation, due to the missing register information from the replaced instruction.

But then I realized - dalvik doesn't validate dead code :). By always replacing the deodexable instructions with a throw, it renders the following code really dead. Before, in the cases where I was replacing them with a different invoke instruction, dalvik still thought that execution could continue on past the invoke, and so it would procede to validate the following code. Since execution can never procede past a throw, dalvik's verifier never reaches the following dead code, and I don't have to worry about making it verification safe - I can just leave it as-is instead of commenting it out. I just have to replace any other dead odex instructions in the following code with a throw as well.

[JesusFreke]

Comment #6 originally posted by JesusFreke on 2010-06-12T02:31:39.000Z:

Just wanted to let you know that everything is well for me after your latest update. Deodexed Froyo is on my n1 with no issues atm. Keep up the good work JF!

[JesusFreke]

Comment #7 originally posted by JesusFreke on 2010-06-12T15:53:03.000Z:

Great! Thanks for trying it out and letting me know Paul and jrEE2kX :)

[JesusFreke]

Comment #8 originally posted by JesusFreke on 2010-06-13T21:03:40.000Z:

The changes have been merged to trunk, and are included in 1.2.3.