Smali error with FRF83 about smali

[JesusFreke]

Comment #1 originally posted by JesusFreke on 2010-06-25T13:23:25.000Z:

Did you modify the file at all?

Also, can you pastebin the snippet of smali code that it is complaining about?

[JesusFreke]

Comment #2 originally posted by JesusFreke on 2010-06-25T21:57:25.000Z:

Yes, file was modified here on statisbaricon.smalli to modify date text color to cyan:

.line 60
const/high16 v6, -0xff0001

I ran it without editing it and smali worked fine, but once edited to change color it errors.

Attached if both the classout folder zipped. Unzip so you can run smali yourself and see it if gives you the error also. And attached is the statisbaricon.smali file where the code was changed.

[JesusFreke]

Comment #3 originally posted by JesusFreke on 2010-06-25T23:39:43.000Z:

This is the expected behavior. That instruction takes the specified short value (16 bits) and then shifts it left by 16 bits and loads it into the specified register. But the literal value you are trying to use can't fit into 16 bits, and so it (correctly) errors out.

The literal value for that instruction is limited to 16 bits, because anything more than 16 bits would get shifted off when the left shift is performed. This instruction can obviously only be used when the literal value you want only contains zeros in the low-order 16 bits. But for the cyan color, the low order 16 bits are actually all 1s. So you can't use the const/high16 instruction.

Also: Why do you insist on using a negative value? Color codes are much easier to specify as a positive value. See my comments about this here: http://forum.sdx-developers.com/themes/(how-to)change-lockscreen-clockdatenetwork-font-color/msg54854/#msg54854

If you want a cyan color (i.e. # 00FFFF RGB), you should use

const v6, 0xff00ffff

[JesusFreke]

Comment #4 originally posted by JesusFreke on 2010-06-26T05:04:40.000Z:

Sweet!!!! Your code fix worked!!!!!!

Posted credits for you for helping crack the color code!

http://forum.xda-developers.com/showthread.php?t=700703