GithubHelp home page GithubHelp logo

Comments (14)

jonitis avatar jonitis commented on August 16, 2024

One more suspicious thing in section 3.6.
It says the expected<T, void> vocabularity type means. Is "vocabularity" here intentional? Or "vocabulary type" was meant instead?

from papers.

jonitis avatar jonitis commented on August 16, 2024

Section 3.7
In addition std::optional has already be delivered in C++17. "already be"->"already been"?

from papers.

jonitis avatar jonitis commented on August 16, 2024

Section 3.10
the use of operator* would be more appropriated.. "more appropriated"->"more appropriate"?

from papers.

jonitis avatar jonitis commented on August 16, 2024

Section 3.11
The rational described in. "rational"->"rationale"?

from papers.

jonitis avatar jonitis commented on August 16, 2024

Hmm. Section name "3.11. Explicit conversion to bool" talks about explicit conversion to bool, but given sample code
if (expected<char, errc> ch = readNextChar()) { to my eye looks implicit.

from papers.

jonitis avatar jonitis commented on August 16, 2024

Section 3.13.
Again potentially wrong use of "rational " instead of "rationale ". The document has 3 such uses. The first one is in the beginning of document.

from papers.

jonitis avatar jonitis commented on August 16, 2024

Section 3.14
Again talking about explicit conversion to bool, but sample shows implicit conversion:
if (p) use(*p);

from papers.

jonitis avatar jonitis commented on August 16, 2024

Section 3.16
but here the exception throw is given by the user. "exception throw"->"exception thrown"?

from papers.

jonitis avatar jonitis commented on August 16, 2024

Section 3.17
// won’t throw comment is awkwardly placed. Intent is to say that r.error() won't throw, not that getInt() won't do it.

    auto r = getInt(); // won’t throw
    if (!r && r.error() == errc::empty_stream) {

from papers.

jonitis avatar jonitis commented on August 16, 2024

Section 3.19
has the same semantics than optional. "than"->"as"?

from papers.

jonitis avatar jonitis commented on August 16, 2024

Section 3.20
C++ does not have concepts yet. It does now.

from papers.

jonitis avatar jonitis commented on August 16, 2024

Section 3.23
the semantics and rationale is the same than in [N3672]. "same than in"->"same as in"?

from papers.

jonitis avatar jonitis commented on August 16, 2024

Section 3.26
Each operations on expected<T, E> have different requirements and may be disable if T or E doesn’t respect these requirements..
"may be disable"->"may be disabled"?

from papers.

jfbastien avatar jfbastien commented on August 16, 2024

The paper is already in the standard, issues should go to LWG: https://isocpp.org/std/submit-issue

from papers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.