Comments (14)
One more suspicious thing in section 3.6.
It says the expected<T, void> vocabularity type means
. Is "vocabularity" here intentional? Or "vocabulary type" was meant instead?
from papers.
Section 3.7
In addition std::optional has already be delivered in C++17
. "already be"->"already been"?
from papers.
Section 3.10
the use of operator* would be more appropriated.
. "more appropriated"->"more appropriate"?
from papers.
Section 3.11
The rational described in
. "rational"->"rationale"?
from papers.
Hmm. Section name "3.11. Explicit conversion to bool" talks about explicit conversion to bool, but given sample code
if (expected<char, errc> ch = readNextChar()) {
to my eye looks implicit.
from papers.
Section 3.13.
Again potentially wrong use of "rational " instead of "rationale ". The document has 3 such uses. The first one is in the beginning of document.
from papers.
Section 3.14
Again talking about explicit conversion to bool, but sample shows implicit conversion:
if (p) use(*p);
from papers.
Section 3.16
but here the exception throw is given by the user
. "exception throw"->"exception thrown"?
from papers.
Section 3.17
// won’t throw
comment is awkwardly placed. Intent is to say that r.error()
won't throw, not that getInt()
won't do it.
auto r = getInt(); // won’t throw
if (!r && r.error() == errc::empty_stream) {
from papers.
Section 3.19
has the same semantics than optional
. "than"->"as"?
from papers.
Section 3.20
C++ does not have concepts yet
. It does now.
from papers.
Section 3.23
the semantics and rationale is the same than in [N3672]
. "same than in"->"same as in"?
from papers.
Section 3.26
Each operations on expected<T, E> have different requirements and may be disable if T or E doesn’t respect these requirements.
.
"may be disable"->"may be disabled"?
from papers.
The paper is already in the standard, issues should go to LWG: https://isocpp.org/std/submit-issue
from papers.
Related Issues (20)
- D0323r5: what kind of type is the E in unexpected<E>? HOT 2
- D0323r5: the exposition only unexpect is ambiguous with the unexpect tag instance
- D0323r5: How to describe the wording for the expected<void,E> specialization?
- D0323r5: What kind of type can be the T in expected<T,E> HOT 3
- D0323r6: unexpected<E> should be trivial if E is trivial HOT 2
- D0323r6: expected<T,E> and [[nodiscard]] attribute
- D0323r6: expected should propagate copy/move triviality as proposed for optional/variant
- D0323r6: bad_expected_access error interface and system_error
- D0323r6: expected::emplace should return a reference as optional does HOT 1
- D0323r6: Fix expected::swap wording
- D0323r6: Ill formed signatures for expected<void, E> HOT 1
- D0323r6: Do we really want in-place construction for expected<void, E>? HOT 2
- Broken source links on open-std.org HOT 1
- D0323R9: Inconsistent requirement and effects
- D0323R9: wrong value category for unexpected(const unexpected<Err>&) constructor HOT 1
- P0323R9: Various Omissions and Errors HOT 2
- N4455: Undefined variable z in sample HOT 1
- N4455: Incorrect claim about fetch_add(0) HOT 1
- p0323r7 avoid explicit throw an exception, including bad_access_expected HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from papers.