Exported files cut off after '#' character about tyto

[user178392143]

My bad; I closed this by mistake. It's still an issue. (The Close button is next to the window for adding a new comment so I thought it would close that, not close my issue!)

[jh3y]

Hey @edemond-clarity ,

Have only just seen this. Will have to have a look when I get a minute. I can only imagine, it's some kind of encoding issue that needs a piece of regex to pick up on #. Because # wouldn't invalidate the json.

Seems a little strange.

Thanks for issuing ;)

[jh3y]

Right so had a quick look at this and actually thinking about this it kinda makes sense now.

The way in which the export works is by clicking an invisible anchor tag with the href set to the json content.

Because # is a special character in the href property of an anchor tag, that's why it's cutting off the content. The json being generated is fine but what will have to be done is I'll have to actually write a replace encoding of my own just for the # character.

So I think when export I'll do something like replace with @tyto-hash and then when importing, just change that back out to #.

@jh3y

[jh3y]

So I spent a few moments and fixed this up for you.

I've added in an object that manages escapes and their used defined equivalents.

tyto.prototype._escapes = {
    "#": "@tyto-hash"
}

Then before exporting and importing a new function is run that will encode or decode the string approriately with those user defined escapes.

tyto.prototype._decodeJSON = function(jsonString) {
    var escape, regex;
    tyto = this;
    if (jsonString !== undefined) {
        for (escape in tyto._escapes) {
            regex = new RegExp(tyto._escapes[escape], 'g');
            jsonString = jsonString.replace(regex, escape);
        }
    }
    return jsonString;
}; 

This seems to fix it. I'll upload to the pages branch too.

Thanks for raising this!

@jh3y

[user178392143]

Thanks, appreciate you looking into it -- works great!

[jh3y]

No problem, anytime.

The solution should be pretty reliable and can use the mechanics of it for some of the future features hopefully.

@jh3y