Test classes should be published under scope test about action-controller

[jhannes]

Perhaps I should extract org.fakeservlet to a separate module? What do you think, @norrs ?

[jhannes]

Thanks for the issue, @norrs. Turns out this oversight had created two bad dependencies from the core of action-controller to assertj. Great to get that resolved!

[norrs]

@jhannes I thought this got fixed, but I guess I gave a bit too quick feedback.

It still pulls in the fakeservlet as a transetive dependency ( https://github.com/jhannes/action-controller/blob/master/action-controller/pom.xml#L103 ) where https://github.com/jhannes/action-controller/blob/master/fake-servlet/src/main/java/org/fakeservlet/FakeServletResponse.java#L17 .

We internally can work around it by excluding fake-servlet and pull it in directly as a test dependency, as I guess the idea is that fake-servlet is a test dependency, especially due to the junit import assert.

[jhannes]

Whops. That was a mistake. I've pushed a change which will be included in the next release.

Actually, the class FakeApiClient in production scope uses fake servlet. It's very useful to to test your own controllers, but it implements the interface ApiClient, which is also useful for any http-clients. Because of this, I could not make fake-servlet into test-scope for action-controller, but I've now made it optional.