GithubHelp home page GithubHelp logo

Comments (8)

cention-sany avatar cention-sany commented on August 28, 2024 2

Just wanna comment that package https://github.com/cention-sany/utf7 is https://tools.ietf.org/html/rfc2152 compliance meanwhile https://github.com/emersion/go-imap/tree/v1/utf7 seem to be https://tools.ietf.org/html/rfc3501#section-5.1.3 which actually two slightly different UTF-7.

from enmime.

deepakprabhakara avatar deepakprabhakara commented on August 28, 2024

Looks like cp-850 and ibm850 is charmap.CodePage850

from enmime.

jhillyerd avatar jhillyerd commented on August 28, 2024

Looks like you took care of most of these. Seems like Go does not support UTF-7 out of the box, not sure if that's because Rob Pike invented UTF-8 and doesn't want it. We could leverage:

https://github.com/cention-sany/utf7

@cention-sany appears to make use of a heavily modified version of the older go.enmime

I'd like to avoid adding a bunch of dependencies if possible, but I'd rather one import than bring in iconv, since it wraps a C library; complicating the build.

from enmime.

deepakprabhakara avatar deepakprabhakara commented on August 28, 2024

Sounds good to me, I'd avoid iconv as well.

from enmime.

jhillyerd avatar jhillyerd commented on August 28, 2024

Looks like https://github.com/emersion/go-imap/tree/v1/utf7 may be a more idiomatic implementation. Turns out that UTF-7 was actually defined in the IMAP RFC.

from enmime.

jhillyerd avatar jhillyerd commented on August 28, 2024

Good to know, skimming rfc2152, it was specifically designed for internet mail content, so your implementation would be the better choice for enmime.

from enmime.

deepakprabhakara avatar deepakprabhakara commented on August 28, 2024

@jhillyerd Nice one

from enmime.

jhillyerd avatar jhillyerd commented on August 28, 2024

If I had known it was only going to take 3 lines of code to implement, I might not have waited two years to fix this. 🙄

from enmime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.