Comments (8)
Indeed, the tests rely on liquibase regardless of the database configuration.
Would definitively make sense to add a guard to prevent data migration related files to be produced.
For instance here
https://github.com/jhipster/jhipster-quarkus/blob/master/generators/server/templates/quarkus/src/test/java/package/web/rest/UserResourceTest.java.ejs#L93
adding
<%_ if (databaseType === 'sql') { _%>
@BeforeEach
public void databaseFixture() {
try (Liquibase liquibase = liquibaseFactory.createLiquibase()) {
liquibase.dropAll();
liquibase.validate();
liquibase.update(liquibaseFactory.createContexts(), liquibaseFactory.createLabels());
} catch (Exception e) {
e.printStackTrace();
}
}
<%_ }%>
Would do the job.
Fancy a PR?
from generator-jhipster-quarkus.
will do at the weekend
from generator-jhipster-quarkus.
Hey @sgulci were you able to get to this? If not maybe we can pick it up in the JHipster code day tomorrow. LMK.
from generator-jhipster-quarkus.
Ohh then you can pickup for jhipster code
from generator-jhipster-quarkus.
I made a start on this but could use another pair of eyes on it. This branch eliminates the liquibase errors but I still see 3 skipped tests once it's complete so I don't know if that's acceptable: https://github.com/nshaw/jhipster-quarkus/tree/76-no-db-tests-fail.
from generator-jhipster-quarkus.
hi,
I think the problem is more complex than that. I've checked your branch @nshaw but I thinks should include the data partial file. At the same time we have to add conditions on entities and User to not have @entity or any related code to Hibernate or JPA.
tests are failing because all the code related to databases are still presents and it tries to connect to a db that does not exists.
from generator-jhipster-quarkus.
@avdev4j feel free to start from scratch if you have time to dig into this. I'm afraid I made a first attempt and then never made it back to it.
from generator-jhipster-quarkus.
Hi @nshaw don't worry I'm working on it. Basically, an important part of the generated code will be removed when selected no db.
Pleas take a look of #122
Have a good day
from generator-jhipster-quarkus.
Related Issues (20)
- e2e test failure in application generated using imperative-sql-jwt-maven-no-db.jdl
- e2e test failure in application generated using imperative-ngx-oauth2-maven-mysql-caffeine.jdl
- Scheduled Native CI workflow jobs are failing with h2 dependency error
- Support Quarkus 2.16.1.Final version
- Upgrade Mongock dependency to v5.1.0 HOT 7
- Not able to run this blueprint HOT 5
- Unable to connect to Keycloak when running in a container
- Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './cli/utils' is not defined by "exports" in C:\Users\jpayneau\AppData\Roaming\npm\node_modules\generator-jhipster-quarkus\node_modules\generator-jhipster\package.json HOT 5
- Kotlin support? HOT 2
- `app.yml` docker file contains Spring specific environment properties to override configurations HOT 1
- Release v3.0 with Quarkus 3 support HOT 11
- Error when generate Jhipter and Quarkus in MacOS HOT 7
- "no file name or template provided" when importing from JDL file HOT 2
- Service classes in wrong package HOT 1
- Dependabot auto-merge needs workflows status requirements HOT 6
- ehcache caching option seems to not work
- Error when generating a microservice application
- The build fails due to an error in your SCSS code.
- Release 3.1.0 with JHipster 8.2 support HOT 4
- Classes not generated when creating a new microsservice application
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from generator-jhipster-quarkus.