type error when rewire'ing const about rewire

[justinrush]

You can see this in a unit test on the main branch by:

• adding an export to testLib/someOtherModule.js: exports.meh = () => {return "meh";}
• import it in testLib/constModule.js: const { meh } = require("./someOtherModule");
• add this test case to testLib/sharedTestCases.js:

    it("should be possible to re-assign const required methods", function () {
        var test = rewire("./constModule.js");

        test.__set__({meh: () => {return "bleh"; }});
        const val = test.meh();

        expect(val).to.be("bleh");
    });

[georgezlei]

I have an interesting finding.

If you rewire a js module below, a type error will be thrown saying the constant variable cannot be assigned.

target.js

const a = 1;
a = 2;

function handler() {}

However, a slight change will make the error disappear.

const a = 1;
a = 2;

async function handler() {}

I haven't checked the rewire source yet and have no idea which behaviour is correct. But it seems that the keyword async triggers another parsing system that changes the constant to a normal variable.

[kswanny]

@georgezlei + 1 on this, found this out today too. I think the latter is incorrect, becasue it means tests will pass gracefully if you accidently re-assign a const.

[georgezlei]

Disagree with the conclusion. The constant re-assignment can be easily detected by the lint tool and it doesn't have to be the responsibility of the unit test. On the other hand, enabling constant re-assignment can help to mock the dependencies of the target module. Think of the below example in your target module:

const dep = require('dependency');