Comments (2)
Jay's fork already has it. If you can fork the current master branch and add the feature to it, then sure, I'll accept the PR.
Then again, Disqus does not necessarily need a backend modifications, which I'd rather keep to bare minimum. Therefore, if you alternatively want to write a wiki page how to add Disqus's JS snippet onto the templates, I'd be happy as well.
e: In general, my goal was to keep JavaScript in bare minimum when it comes to the main application. Users may add JavaScript to the site if they want to, but I don't want to ship any unnecessary JS code.
from vertigo.
Yea, its not really required to be added to the core. I only added it
because i think it was easier that way to maintain
On May 20, 2015 6:32 AM, "Juuso Haavisto" [email protected] wrote:
Jay's fork https://github.com/jayrox/vertigo already has it. If you can
fork the current master branch and add the feature to it, then sure, I'll
accept the PR.Then again, Disqus does not necessarily need a backend modifications,
which I'd rather keep to bare minimum. Therefore, if you alternatively want
to write a wiki page how to add Disqus's JS snippet onto the templates, I'd
be happy as well.—
Reply to this email directly or view it on GitHub
#39 (comment).
from vertigo.
Related Issues (20)
- Replace Martini with idiomatic HTTP middleware HOT 16
- Titles and slugs
- Creation date HOT 2
- feed and atom issue HOT 1
- login/register links while signed-in HOT 13
- error handler and submit button HOT 5
- Should ID be string or int? HOT 3
- time issue HOT 6
- Markdown as default post format HOT 6
- Search and clauses HOT 18
- Pretty emails HOT 1
- source installation errors HOT 2
- installation from source issues HOT 6
- posts per page/pagination HOT 1
- Effort to compile Vertigo on Windows dev box fails HOT 4
- issue on addons HOT 5
- Unable 2 create session HOT 1
- Message "layout" is undefined HOT 1
- Does Heroku charge from creadit card for custom domain HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vertigo.