GithubHelp home page GithubHelp logo

Comments (4)

jillesvangurp avatar jillesvangurp commented on May 28, 2024 1

I can change the dependency to implementation if you want. That should solve the problem.

from kt-search.

jillesvangurp avatar jillesvangurp commented on May 28, 2024

Interesting. I would suggest making this an independent library. Basically, all you have to do is implement RestClient and you should be able to use it with the SearchClient. This is exactly why I added support for this. I'd like to keep this out of the main repository though.

Alternatively, you could configure ktor client to use your existing client: https://ktor.io/docs/http-client-engines.html#limitations. I'm not familiar with Armeria but they have jetty and a few other client backends.

My current implementation defaults to the Java httpclient on the JVM. But there several other engines that you can configure. We had some issues with CIO a few months ago.

from kt-search.

Dogacel avatar Dogacel commented on May 28, 2024

Interesting. I would suggest making this an independent library. Basically, all you have to do is implement RestClient and you should be able to use it with the SearchClient. This is exactly why I added support for this. I'd like to keep this out of the main repository though.

Alternatively, you could configure ktor client to use your existing client: https://ktor.io/docs/http-client-engines.html#limitations. I'm not familiar with Armeria but they have jetty and a few other client backends.

Because it is an api dependency inside the search-client, it is exposed to library consumers, which worries me.

My current implementation defaults to the Java httpclient on the JVM. But there several other engines that you can configure. We had some issues with CIO a few months ago.

I don't get it, isn't Ktor shipped with this library by default?

from kt-search.

jillesvangurp avatar jillesvangurp commented on May 28, 2024

I fixed the dependencies in 2.1.2

from kt-search.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.