Comments (6)
For starters: you don't need to call "base2.DOM.bind(window)". In fact, window
is not a DOM object, and I
don't know what happens.
Dean: should we introduce a test in Binding.bind?
Something like if(!object.nodeType) throw Error("DOM Node expected")
Bug is confirmed for Safari 2, but is doesn't appear in WebKit.
The difference in execution happens in BOM.detect. The statement (the try/catch
part):
eval("r=!!(getComputedStyle)")
throws the error "ReferenceError - Can't find variable: getComputedStyle" in
Safari 2, but not in WebKit.
Safari 2 *does* support getComputedStyle though.
Code path:
-Document.bind
-AbstractView+ViewCSS.bind(document.defaultView)
-ViewCSS[@!(getComputedStyle)]
Original comment by [email protected]
on 17 Jul 2007 at 8:16
- Changed state: Accepted
- Added labels: Browser-Safari, Module-base2.DOM
from base2.
As it appears, Safari2 is defining document.defaultView.getComputedStyle, but
not window.getComputedStyle.
That explains why the test fails.
Firefox2, Opera9 and IE6 all do define document.defaultView.getComputedStyle,
so change the test in ViewCSS
to that.
Solved in /trunk/src, not yet in /trunk/lib.
Original comment by [email protected]
on 17 Jul 2007 at 8:47
- Changed state: Fixed
from base2.
> Dean: should we introduce a test in Binding.bind?
Something like if(!object.nodeType) throw Error("DOM Node expected")
Later. ;-) At the moment, binding is encouraged through the DOM.bind() method
not
through the Binding's individual bind() methods. But we can put some captures
there
for when we are in strict mode.
Incidentally, there is a feature of packer that treats lines that start with
";;;" as
single line comments:
e.g.
;;; console.log("this will show up in the source code but not in packed code");
I'm re-opening this bug because I quite like a global getComputedStyle()
function. It
won't do any harm to add it to the window object.
Original comment by [email protected]
on 17 Jul 2007 at 9:30
- Changed state: Re-open
from base2.
Original comment by [email protected]
on 17 Jul 2007 at 9:31
from base2.
Sorry, I didn't check in until just now. trunk/lib still has to be generated
(I'm working on that).
DOM.bind(window) actually doesn't to anything. There's already a switch for
that in DOM.bind (I missed that
one).
window.getComputedStyle sounds good. Your call?
Original comment by [email protected]
on 17 Jul 2007 at 10:07
from base2.
This bug is fixed with the change you made. As to the window.getComputedStyle()
issue, that is covered in another bug.
Original comment by [email protected]
on 23 Jul 2007 at 9:06
- Changed state: Fixed
from base2.
Related Issues (20)
- Please add Array2.make HOT 2
- 'Unspecified error' when loading a page via iframe in IE8.
- Function.bind() defined in Firefox 4 conflicts with Base2's own bind()s. HOT 1
- base62 encoding shrinked script fails with 3.1 but works with 3.0 HOT 3
- Contact to the owner of the project? HOT 1
- DOMContentLoaded does not fire in Safari 3.0.4 (and possibly other versions) HOT 1
- IE throws "Unspecified Error" when calling some methods or accessing some properties of elements not attached to a document
- base2.jsb.eventDispatcher fails to dispatch (delegated?) events under IE9
- Listeners for (before)?(cut|copy|paste) events are not executed in IE7-9 HOT 1
- Patch for /trunk/src/apps/MiniWeb/Client.js
- Patch for /trunk/src/apps/MiniWeb/Client.js
- document not geting extended.
- getting opacity in getComputedPropertyValue of ViewCSS returns empty string on element without opacity set
- Eclipse "Syntax error on token "new", ArrayLiteralHeader expected after this token", l. 19 of v1.0.2 of base2.js HOT 3
- Consider relying on HTML ClassList API
- :checked pseudo-class doesn't match selected option elements.
- Non ascii strings broken when encoded HOT 1
- classList.remove can incorrectly trigger IE's onpropertychange event.
- Allow Base cast specialization HOT 1
- Patch for /trunk/src/apps/packer/Base62.js HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from base2.