Update devDependencies for karma and jasmine about oboe.js

[jimhigson]

Yeah, I agree. Jasmine 2.0 is much better than 1.3.

There are about 1,000 tests at the moment though and this is quite a lot of work for something which hasn't in the past created any practical problems.

I just made a fresh clone and npm install worked ok. Does this not work for you? Peer dependencies are always tricky but old versions should still work with packages from the same era.

[jwahyoung]

When I cloned and did an npm install, I ran into the issues outlined above.
I don't think that Karma is in your devDependencies by default, so it might
be looking at the version you have installed globally? Not sure.

There are definitely a lot of tests, but I've realized that it's the same
few tests that are run multiple times, so it's not as bad as the test
output would make it seem. I forked and actually started to work on this,
attempting to migrate the test syntax over to 2.0 format; I was able to fix
quite a few things, but I'm running into issues where objects don't have
certain methods. (For instance, actual.map doesn't exist, so I had to use
Array.prototype.map.call(actual, ...). ) I'll give it another shot and
see what I can fix

On Sat, Jan 10, 2015 at 11:39 AM, Jim Higson [email protected]
wrote:

Yeah, I agree. Jasmine 2.0 is much better than 1.3.

There are about 1,000 tests at the moment though and this is quite a lot
of work for something which hasn't in the past created any practical
problems.

I just made a fresh clone and npm install worked ok. Does this not work
for you? Peer dependencies are always tricky but old versions should still
work with packages from the same era.

—
Reply to this email directly or view it on GitHub
#57 (comment).

[jimhigson]

That's awesome. Let me know how you get on and if anything isn't very obvious how to convert.

I don't seem to have karma globally, not sure why npm install didn't work for you, but I agree that updating the dependencies is the correct way to deal with this.

jimhigson@Jims-Air ~ [1]> npm list -g --depth=0
/usr/local/lib
├── [email protected]
├── [email protected]
├── [email protected] -> /Users/jimhigson/Sites/shop-search/elasticSearchRest
├── [email protected] -> /Users/jimhigson/Sites/shop-search/fetchQueue
├── [email protected]
├── [email protected]
├── [email protected] -> /Users/jimhigson/Sites/shop-search/generic-queue
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] -> /Users/jimhigson/Sites/jus
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] -> /Users/jimhigson/Sites/oboe.js
├── [email protected] -> /Users/jimhigson/Sites/simple-barrier
├── [email protected]
└── [email protected]

[jwahyoung]

I do have a question, actually - are all of the tests passing in your
current build?

On Sat, Jan 10, 2015 at 1:13 PM, Jim Higson [email protected]
wrote:

That's awesome. Let me know how you get on and if anything isn't very
obvious how to convert.

I don't seem to have karma globally, not sure why npm install didn't work
for you, but I agree that updating the dependencies is the correct way to
deal with this.

jimhigson@Jims-Air ~ [1]> npm list -g --depth=0
/usr/local/lib
├── [email protected]
├── [email protected]
├── [email protected] -> /Users/jimhigson/Sites/shop-search/elasticSearchRest
├── [email protected] -> /Users/jimhigson/Sites/shop-search/fetchQueue
├── [email protected]
├── [email protected]
├── [email protected] -> /Users/jimhigson/Sites/shop-search/generic-queue
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] -> /Users/jimhigson/Sites/jus
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] -> /Users/jimhigson/Sites/oboe.js
├── [email protected] -> /Users/jimhigson/Sites/simple-barrier
├── [email protected]
└── [email protected]

—
Reply to this email directly or view it on GitHub
#57 (comment).

[jimhigson]

I'm on my iPad now so can't run this moment but they were passing when I
last checked in and I haven't had a failure message from Travis so will be
building there too.

If you're getting a build failure on master please post the log

On Saturday, January 10, 2015, Jedd Ahyoung [email protected]
wrote:

I do have a question, actually - are all of the tests passing in your
current build?

On Sat, Jan 10, 2015 at 1:13 PM, Jim Higson <[email protected]
javascript:_e(%7B%7D,'cvml','[email protected]');>
wrote:

That's awesome. Let me know how you get on and if anything isn't very
obvious how to convert.

I don't seem to have karma globally, not sure why npm install didn't
work
for you, but I agree that updating the dependencies is the correct way
to
deal with this.

jimhigson@Jims-Air ~ [1]> npm list -g --depth=0
/usr/local/lib
├── [email protected]
├── [email protected]
├── [email protected] ->
/Users/jimhigson/Sites/shop-search/elasticSearchRest
├── [email protected] -> /Users/jimhigson/Sites/shop-search/fetchQueue
├── [email protected]
├── [email protected]
├── [email protected] ->
/Users/jimhigson/Sites/shop-search/generic-queue
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] -> /Users/jimhigson/Sites/jus
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] -> /Users/jimhigson/Sites/oboe.js
├── [email protected] -> /Users/jimhigson/Sites/simple-barrier
├── [email protected]
└── [email protected]

—
Reply to this email directly or view it on GitHub
#57 (comment).

—
Reply to this email directly or view it on GitHub
#57 (comment).

[jimhigson]

Passing on the Ci: https://travis-ci.org/jimhigson/oboe.js