Potentially incompatible with Python 3.12? about fanficfare

[JimmXinu]

I will look into that, but I don't support FFF plugin on vendored versions of Calibre, only the official calibre releases.

[natrys]

@JimmXinu I am hitting this too. Installed in a fresh venv of 3.12, without calibre. The problem is probably not calibre, you are vendoring six.py here except it's an old version:

https://github.com/JimmXinu/FanFicFare/blob/main/fanficfare/six.py

I have replaced that file with newer version, and it seems to work now. But maybe you shouldn't vendor this?

[JimmXinu]

@natrys 's comment did lead me to investigate further and they are right; there's a load issue and updating six does address it. Thanks for pointing that out.

(FFF includes six because older versions of Calibre include an even older version of six.)

I've uploaded test versions in the usual places.

[gramer23]

It turns out that on Python 3.12, configparser's readfp() method was renamed to read_file(). If anyone else has the problem where every download fails because it can't find readfp, simply renaming every occurrence fixes every error. There are two calls in fff_util.py and two others in fanficfare/cli.py. (I'm talking about the paths inside the plugin's zip, since that's probably the easiest place to edit the files without repackaging.)

I guess this might be useful for even the official version when Calibre also moves on. Until then, this is a good workaround for those who can't or don't want to install a Python 3.11 interpreter just to download some stories.

[JimmXinu]

There's also one in jobs.py.

This issue is only with Calibre and Python 3.12. Which is technically outside what I support. But it's a relatively easy fix. Test version up.

[gramer23]

I didn't catch the jobs.py one, I have no idea how it kept working anyway. Thank you for the help. I've tested it on a relatively big download and I didn't find any errors on the newest Calibre (6.28.1) and Python 3.12.

[JimmXinu]

In jobs.py it's contingent on settings.

I'm going to close this, but you can reopen it if you find more 3.12 issues.

[JimmXinu]

I'll look into the SyntaxWarning: invalid escape sequence '\.' warning, which I expect is not uncommon in FFF.

The actual error is ModuleNotFoundError: No module named 'fanficfare.six.moves' which is, as far as I can tell, caused by a broken vendored Calibre version.