Comments (2)
I only support FanFicFare on the official Calibre releases, and Calibre in turn bundles its dependencies--including python--for exactly this sort of reason. (Most dependencies bundled in FanFicFare are for older versions of Calibre.)
from fanficfare.
I'm sorry but I have to strongly object to that reply.
- The commit removing appengine from urllib3 claims it was only available for python 2.7, calibre now ships with 3.11 as a minimum. urllib3/urllib3@6af53ac
- Actually, the offending code was only on GAE's python implementation, so it probably wouldn't work on any of the shipped calibre versions unless they were doing something screwy.
- Calibre's doesn't seem to bundle urllib3 and only mentions it in the Arch CI setup
- The offending code is in your bundled version of requests-toolbelt which removed appengine support in May of this year https://github.com/requests/toolbelt/blob/master/HISTORY.rst
- toolbelt is only included because it's a dep of cloudscraper... which you have bundled at a 2 year out of date and mangled version of 1.2.58... mangled because that project dropped py2 support in 2020, but it doesn't work anyway because cloudscaper literally only works if you update it when the CF updates break it... which is presumably why there are so many issues about it not working and the wiki says to use cfprox
- cloudscraper is only used by default for a single site now... quotev.com 53dd007
- ... which turns out to be a site that doesn't even use cloudflare: https://checkforcloudflare.selesti.com/?q=https://quotev.com
All of this easily found by just checking what versions are being bundled by Calibre and FFF.
So, short version: your bundled version of toolbelt is trying to import something that won't work on modern Calibre (py2 was dropped in calibre 5.0) and appears to be broken specifically because you aren't forcing the use of the version of urllib3 you bundled, to power a feature that doesn't work on any version, for a site that doesn't use that feature.
All of which also raises the question: Are you tracking and backporting security bugs for all the packages you have bundled? You seem to have some really old code in there.
from fanficfare.
Related Issues (20)
- DeviantArt Adapter: Failure to Download Story HOT 1
- Wrong number of threadmarks being reported for Sufficient Velocity HOT 1
- Is it possible to make FFF ignore the 403 errors. HOT 2
- Get ALL story urls from existing books upgrade HOT 1
- Fanfiction.net stories give a HTTP error each time HOT 1
- [BUG] Error Updating Metadata HOT 1
- fanficfare linux vs windows speed difference HOT 1
- Errors fetching information on the plugin now generate modal error boxes instead of just reporting on the job log like before HOT 1
- Error when downloading from deviant art with login credentials HOT 21
- Spacebattles Threadmarks Pagination Update HOT 1
- [Question] For the Browser Cache method: only check first and last chapter HOT 1
- browser cache path for fanfiction.net doesn't work HOT 9
- Update AO3 anthology not working when a series URL is used HOT 7
- Any way to improve tables on Kindle? HOT 3
- Literotica changes after site UI revamp HOT 35
- Existing story produces 'Story does not exist' error HOT 1
- [literotica.com] Download all Story from User HOT 3
- Ficbook.net categories aren't showing up
- QuestionableQuesting.com Site Changed HOT 4
- deviantart.com probably needs force login option HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fanficfare.