Comments (2)
Thanks for your interest in the project :)
I don't know if I'm convinced this project needs react 18 + vite + pnpm + typescript. In hindsight, it had way too much tooling for what it is. I haven't revisited this project in a long time and now I can't even get it to deploy because the build won't work and I don't really have the interest/time to look into why at the moment.
The site itself is really just a static page. If I had to redo this, I would make it much simpler and just use vanilla HTML/CSS/JS with JSdoc annotations for any in-editor typing. In other words, my recommendation to make this up to date would be:
- Strip out React
- Use JSdoc annotations for any typing
- Get rid of CRA altogether
- Use npm (if necessary) for dev deps
- Make the site require no build step
That would make ongoing maintenance of this site into the future much easier. And it would decrease the amount of complexity in setting up, developing, and deploying the site (not to mention reduce the amount of code shipped to the client).
All that said, I'm not really convinced this project needs a technical facelift. What it needs is more accurate, up-to-date team information with the ability to accurately cite the source for its colors. Most of the original sourcing is no longer accessible.
In other words, this site has more of a content issue than technological one IMO.
Anyhow, I am hesitant to dump a bunch of new tech on something that was already over-tooled when I first made it. If there's any technological change, I'd prefer it be towards simplification instead of modernization.
That said, if you want to work on it because you want to use those particular tools, you're always welcome to fork it and deploy/host it wherever you please :)
from teamcolors.
Thanks for the detailed reply. I get where you are coming from.
I think I will go ahead with forking it and working on these changes in https://github.com/MBM1607/teamcolors.
I saw the source issue as well, for my changes when I have better sources, I will be sure to make a pull request to update only that part in the upstream as well.
from teamcolors.
Related Issues (20)
- Update Minnesota Vikings Logo HOT 2
- Update Dolphins logo HOT 1
- Need Jaguar's SVG HOT 1
- Corrupt Panthers logo HOT 2
- Create "click to copy" HOT 1
- print problem HOT 6
- Green Bay Packers HOT 1
- Broken in IE HOT 4
- MLB official (?) colors HOT 21
- Screen Flickers on initial load HOT 1
- Source for EPL, MLB, MLS, NHL? HOT 2
- Brazilian Series A and B HOT 4
- NBA Hex HOT 2
- Use of SVG logos HOT 4
- Atlanta United and Minnesota United FC HOT 1
- EPL out of date HOT 4
- This repo is missing a "sponsor" button HOT 1
- Washington Redskins is now Washington Commanders HOT 1
- :accessibility: Update `master` branch to `main`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from teamcolors.