deposit: javascript update for some form fields doesn't execute correctly about invenio

[jirikuncar]

@JakeCowton Do you have somewhere the tmp fix we have done together on your machine?

[JakeCowton]

Yes.

  /**
   * Update the value of a field to a new one.
   */
  function handle_field_values(name, value) {
      if (name == 'files'){
          $.each(value, function(i, file){
              id = unique_id();

              new_file = {
                  id: id,
                  name: file.name,
                  size: file.size
              };

              $('#filelist').append(tpl_file_entry.render({
                  id: id,
                  filename: file.name,
                  filesize: getBytesWithUnit(file.size)
              }));
              $('#filelist #' + id).show('fast');
          });
          $('#file-table').show('fast');
      } else {
          clear_error(name);
          has_ckeditor = $('[name=' + name + ']').data('ckeditor');
          if( has_ckeditor === 1) {
              if(CKEDITOR.instances[name].getData(value) != value) {
                  CKEDITOR.instances[name].setData(value);
              }
          } else if (field_lists !== undefined && name in field_lists &&
                     value instanceof Array) {

            var $field = $('#'+name)
            if ($field.hasClass('dynamic-field-list')) {
              // TODO check that number of dynamic fields in the list is greather or equal to value.length
              // #<name> a.add-element .click()
              if ($field.children('.field-list-element').length < value.length) {
                $field.children('.add-element').click();
              }
            }

              for(var i = 0; i < value.length; i++){
                  field_lists[name].update_element(value[i], i);
              }
          } else {
              if($('[name=' + name + ']').val() != value) {
                  $('[name=' + name + ']').val(value);
              }
          }
      }

[jirikuncar]

@JakeCowton A patch would be better.

[JakeCowton]

From 5988a55a3fb8842853393a07a4ea290f6f36bc44 Mon Sep 17 00:00:00 2001
From: Jake Cowton <[email protected]>
Date: Tue, 25 Mar 2014 17:46:13 +0100
Subject: [PATCH 2/2] Data Analysis: Initial Commit

---
 invenio/modules/deposit/static/js/deposit/form.js | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/invenio/modules/deposit/static/js/deposit/form.js b/invenio/modules/deposit/static/js/deposit/form.js
index dd07282..77618e5 100644
--- a/invenio/modules/deposit/static/js/deposit/form.js
+++ b/invenio/modules/deposit/static/js/deposit/form.js
@@ -282,6 +282,16 @@ var DEPOSIT_FORM = (function( $ ){
               }
           } else if (field_lists !== undefined && name in field_lists &&
                      value instanceof Array) {
+
+            var $field = $('#'+name)
+            if ($field.hasClass('dynamic-field-list')) {
+              // TODO check that number of dynamic fields in the list is greather or equal to value.length
+              // #<name> a.add-element .click()
+              if ($field.children('.field-list-element').length < value.length) {
+                $field.children('.add-element').click();
+              }
+            }
+
               for(var i = 0; i < value.length; i++){
                   field_lists[name].update_element(value[i], i);
               }
-- 
1.9.1

[JakeCowton]

@jirikuncar do you have any ideas what the problem here could be?

[jirikuncar]

// TODO check that number of dynamic fields in the list is greather or equal to value.length

Have you implemented the TODO?

[JakeCowton]

Yes. It's the two lines below.