GithubHelp home page GithubHelp logo

Comments (6)

jonathanKingston avatar jonathanKingston commented on July 17, 2024

The example radio I was listening to was BBC radio 6.

from node-sonos-discovery.

jishi avatar jishi commented on July 17, 2024

Yes, it needs to differentiate the rendering between different services. Low priority though because it "works", but if you want to fix it, feel free to send a pull request.

Pointers: Try to identify if other music services has different views.
Radiostations is sort of a list, with different bit rates (that it seems to switch between somehow), make sure that this is considered when selecting the actual metadata.

from node-sonos-discovery.

jonathanKingston avatar jonathanKingston commented on July 17, 2024

@jishi thanks, I thought it was safer to add new keys than merge the meanings. I will do much further debugging. As you mention each station seems to do different things here.

from node-sonos-discovery.

jishi avatar jishi commented on July 17, 2024

Consider that the metadata (or trackinfo you might call it), is the same regardless if it is the http-api or the web-controller that interacts with it. It's preferable that the "info" is standardized and readable, but with a good distinction on how it may differentiate.

Because of that it might be preferable that when it's a radio station, the track name etc is the stationname (instead of uri which seems to be the case today), and album and artist maybe empty, and instead an optional "currently airing" or similar. That way it will interact better with different implementations (consider that someone requests info through the http-api in json-format and populates a display, for example).

from node-sonos-discovery.

jonathanKingston avatar jonathanKingston commented on July 17, 2024

@jishi let me know what you think, I tried it on quite a lot of different stations.

The parsing part probably could do with a bit of a refactor to have it in a function. I noticed the transportMeta also holds the playlist info too which could be used as part of this further refactor.

Certainly its a start to resolve this issue.

from node-sonos-discovery.

jonathanKingston avatar jonathanKingston commented on July 17, 2024

@jishi I fixed the merge conflicts here, not sure if you had any thoughts regarding this.

Fixed in:
#19

from node-sonos-discovery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.