Comments (6)
The example radio I was listening to was BBC radio 6.
from node-sonos-discovery.
Yes, it needs to differentiate the rendering between different services. Low priority though because it "works", but if you want to fix it, feel free to send a pull request.
Pointers: Try to identify if other music services has different views.
Radiostations is sort of a list, with different bit rates (that it seems to switch between somehow), make sure that this is considered when selecting the actual metadata.
from node-sonos-discovery.
@jishi thanks, I thought it was safer to add new keys than merge the meanings. I will do much further debugging. As you mention each station seems to do different things here.
from node-sonos-discovery.
Consider that the metadata (or trackinfo you might call it), is the same regardless if it is the http-api or the web-controller that interacts with it. It's preferable that the "info" is standardized and readable, but with a good distinction on how it may differentiate.
Because of that it might be preferable that when it's a radio station, the track name etc is the stationname (instead of uri which seems to be the case today), and album and artist maybe empty, and instead an optional "currently airing" or similar. That way it will interact better with different implementations (consider that someone requests info through the http-api in json-format and populates a display, for example).
from node-sonos-discovery.
@jishi let me know what you think, I tried it on quite a lot of different stations.
The parsing part probably could do with a bit of a refactor to have it in a function. I noticed the transportMeta also holds the playlist info too which could be used as part of this further refactor.
Certainly its a start to resolve this issue.
from node-sonos-discovery.
@jishi I fixed the merge conflicts here, not sure if you had any thoughts regarding this.
Fixed in:
#19
from node-sonos-discovery.
Related Issues (20)
- If local endpoint changes, subscribe will keep failing to reconnect. HOT 6
- HTTPS Support in lib/helpers/request.js HOT 5
- Question about code, half seconds HOT 3
- BTW: Great project!
- UnhandledPromiseRejectWarning HOT 5
- Implement same features in Java/Android app HOT 4
- npm test fails on spotify HOT 2
- Support switch to Line In and TV HOT 6
- No Metadata when browsing SQ:4 HOT 3
- setting incorrect volume HOT 7
- Uncaught (in promise) TypeError: Cannot read property 'baseUrl' of undefined HOT 1
- Request: Soundbar Input Information
- error: sonos.0 TypeError: Cannot read property '$text' of undefined HOT 5
- How to update libary
- Unable to get state of player
- Audio Delay
- What are all the possible state changes? HOT 2
- Spotify: "Wrong" album art when playing from playlist
- GetFavorites does not return all favorites HOT 3
- exception in recalculateGroupVolume HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-sonos-discovery.