GithubHelp home page GithubHelp logo

Comments (3)

NewEraCracker avatar NewEraCracker commented on July 16, 2024

Looks like this issue is known since 2021:

https://stackoverflow.com/questions/68741890/webrtc-screen-sharing-with-vp9-low-fps
https://bugs.chromium.org/p/webrtc/issues/detail?id=13016

PS: Leaving this here, no warranties express or implied, as a workaround:

--- a/modules/RTC/ScreenObtainer.js
+++ b/modules/RTC/ScreenObtainer.js
@@ -322,7 +322,7 @@ const ScreenObtainer = {
 
         // Set contentHint on the desktop track based on the fps requested.
         if ('contentHint' in desktopTrack) {
-            desktopTrack.contentHint = desktopSharingFrameRate?.max > SS_DEFAULT_FRAME_RATE ? 'motion' : 'detail';
+            desktopTrack.contentHint = (browser.supportsVP9() || desktopSharingFrameRate?.max > SS_DEFAULT_FRAME_RATE) ? 'motion' : 'detail';
         } else {
             logger.warn('MediaStreamTrack contentHint attribute not supported');
         }

Adding here the following:

We never go beyond 1080p screensharing in our application, and the quality is okay with this hack in non-e2ee sessions (vp9) and e2ee sessions (vp8). The contentHint motion would be applied in both cases as chrome supports vp9.

As the workaround seems okay for our usage, I will leave the issue here for maintainer review.

from lib-jitsi-meet.

saghul avatar saghul commented on July 16, 2024

Ping @jallamsetty1

from lib-jitsi-meet.

jallamsetty1 avatar jallamsetty1 commented on July 16, 2024

This is because of https://bugs.chromium.org/p/webrtc/issues/detail?id=13016. If you want higher fps, you can set the desktopSharingFrameRate.max to > 5 and this is configurable via config.js, settings menu and through JitsiConference:setDesktopSharingFrameRate() API.

from lib-jitsi-meet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.