Comments (5)
Thanks. I'm currently doing a pretty massive revamp of the tag system so this one will have to wait until that's done.
from fireplace.
No problem! If I am bombarding you too frequently with these issues, let me know and I can try to queue up more issues that I observe before I pass them along to you.
from fireplace.
No don't worry, file as much as you want, I appreciate it a lot. It helps having someone test stuff for actual situations. =)
But yeah if you have anything immediate, swing by the IRC channel instead. You can try Freenode's Webchat if you don't have an IRC client.
from fireplace.
Phew, done with the tag refactoring.
This is an interesting bug for sure. The true root cause is my lack of support for a "death phase". Deaths currently happen instantaneously.
What this means in practice is that when the yeti hits the wolf, the DAMAGE event is broadcast. That DAMAGE event is what causes the wolf to die, and it is moved to the graveyard during event propagation. During said DAMAGE broadcast, the UPDATE event is re-broadcast all the time to those same entities, and towards the end of the propagation chain is the Aura, which has already been destroyed and whose source is already in the graveyard, but it's still in the event listener.
A real fix for this won't come until I implement the death phase, but I'll see if I can fix it some other way.
from fireplace.
Fixed by the new actions API, which includes proper death events :)
from fireplace.
Related Issues (20)
- Willing to add unittest code HOT 1
- [Test]Sometimes test for test_silvermoon_portal() fails HOT 6
- Secrets with Lord Jaraxxus HOT 5
- [test]Missing steps in attack cycle when Truesilver Champion triggers off Shadowboxer HOT 3
- Is there any way to choose WILD cards? HOT 5
- When Choose Twice, only second choose work. HOT 5
- [test]Spell cycle:Wild Pyromancer deals unexpected damages if it is created by a spell. HOT 2
- [test]solemn vigil does not restore its original cost after one's turn ends HOT 2
- When the card is discarded, it will enter the Zone.GRAVEYARD HOT 3
- Silence bug HOT 2
- [test] Test cases test_medivh fails when summon Sorcerer's Apprentice HOT 1
- [Test] Cenarius' choice EX1_573a needs to "- SELF" HOT 1
- [Suggest]Need more warning tags other than Invalid action
- [Test]Wild growth mana used issue. HOT 2
- build fail HOT 1
- choose one of three RandomCardPicker HOT 3
- small error on rogue.py? HOT 3
- [Test] dual class cards make test failed. HOT 1
- Proposing a PR to fix a few small typos
- where is the requirements.txt? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fireplace.