GithubHelp home page GithubHelp logo

Comments (5)

jleclanche avatar jleclanche commented on May 22, 2024

Thanks. I'm currently doing a pretty massive revamp of the tag system so this one will have to wait until that's done.

from fireplace.

hstoner009 avatar hstoner009 commented on May 22, 2024

No problem! If I am bombarding you too frequently with these issues, let me know and I can try to queue up more issues that I observe before I pass them along to you.

from fireplace.

jleclanche avatar jleclanche commented on May 22, 2024

No don't worry, file as much as you want, I appreciate it a lot. It helps having someone test stuff for actual situations. =)

But yeah if you have anything immediate, swing by the IRC channel instead. You can try Freenode's Webchat if you don't have an IRC client.

from fireplace.

jleclanche avatar jleclanche commented on May 22, 2024

Phew, done with the tag refactoring.

This is an interesting bug for sure. The true root cause is my lack of support for a "death phase". Deaths currently happen instantaneously.

What this means in practice is that when the yeti hits the wolf, the DAMAGE event is broadcast. That DAMAGE event is what causes the wolf to die, and it is moved to the graveyard during event propagation. During said DAMAGE broadcast, the UPDATE event is re-broadcast all the time to those same entities, and towards the end of the propagation chain is the Aura, which has already been destroyed and whose source is already in the graveyard, but it's still in the event listener.

A real fix for this won't come until I implement the death phase, but I'll see if I can fix it some other way.

from fireplace.

jleclanche avatar jleclanche commented on May 22, 2024

Fixed by the new actions API, which includes proper death events :)

from fireplace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.