error Strings must use singlequote quotes about learn-rollup

[stasgavrylov]

@jlengstorf I'm glad I could help, and PR is already waiting. Thanks for pointing me to the article repo.

[jlengstorf]

It looks like ESLint isn't quite set up correctly. Can you point me to the repo where you're getting this error?

[zhangwei900808]

yes, It's found in part-2-starer switch

[jlengstorf]

Sorry, I meant your repo — can you link me to your repo that isn't working?

[stasgavrylov]

@jlengstorf @zhangwei900808
the problem is not in the repo itself, but rather in the article - https://code.lengstorf.com/learn-rollup-js/
I also stumbled across it, but managed to find a solution. In step 3 "Update rollup.config.js" part you put eslint plugin after babel, but it should be placed before, since in that case it lints the code already transpiled by Babel. I'd sent a PR, but the article is not in the repo :)

Btw, thanks for the tutorial, it's awesome.

[jlengstorf]

Thanks, @stasgavrylov! I do keep the articles on GitHub (here's the section you're referencing): https://github.com/jlengstorf/code.lengstorf.com/blob/master/content/blog/learn-rollup-js.md#update-rollupconfigjs-1

If you have time to submit a PR, that would be very much appreciated. Thanks so much for posting the solution here, either way.