Comments (3)
This is the purpose of the modifications.json
file, which is documented here. I'd use that to handle this issue. If you need more guidance after taking a look at those links, let me know :)
from selling-partner-api.
This is the purpose of the
modifications.json
file, which is documented here. I'd use that to handle this issue. If you need more guidance after taking a look at those links, let me know :)
Thanks, didn't noticed that, sorry. Created a pull request.
Note: The generation method touched multiple dozens of files, while one one did in fact change.
I needed to revert a lot of changes done by the process.
All of that changes were changes in formatting. Spaces to intend were changed, the placement of the curly brackets was changed a bit, spaces within the Docblock were changed a bit.
Example constructor before the generation:
public function __construct(
protected array $marketplaceIds,
protected ?array $identifiers = null,
protected ?string $identifiersType = null,
protected ?array $includedData = null,
protected ?string $locale = null,
protected ?string $sellerId = null,
protected ?array $keywords = null,
protected ?array $brandNames = null,
protected ?array $classificationIds = null,
protected ?int $pageSize = null,
protected ?string $pageToken = null,
protected ?string $keywordsLocale = null,
) {}
After generation:
public function __construct(
protected array $marketplaceIds,
protected ?array $identifiers = null,
protected ?string $identifiersType = null,
protected ?array $includedData = null,
protected ?string $locale = null,
protected ?string $sellerId = null,
protected ?array $keywords = null,
protected ?array $brandNames = null,
protected ?array $classificationIds = null,
protected ?int $pageSize = null,
protected ?string $pageToken = null,
protected ?string $keywordsLocale = null,
) {}
Also, the changes we had done to the Deserialies.php Trait were reverted back to the faulty state. The file doesn't state that it is auto generated, but it changes with the schema:generate
command.
I'm a bit in a hurry right now, so I can't dig deeper into this, but I wanted to let you know about that. Maybe there's something missing to unify the generation.
from selling-partner-api.
I think we resolved in this in the PR, but those changes were because the current flow assumes composer lint
will be run after codegen. Maybe I'll update the build process to automatically run the linter.
from selling-partner-api.
Related Issues (20)
- No Data Returned HOT 2
- Wrong Timezone for Datetime Deserializer HOT 4
- Need AWD Models / Requests / Responses HOT 3
- Docs on how to get started with the library needs to be updated HOT 1
- Problem with Catalog API Search Result DTO HOT 1
- How to Update Price for Repricer in a minutes??? HOT 2
- GetMyFeesEstimatesResponse dto() issue HOT 6
- The function ReportsV20210630()->getReportDocument return error 400 HOT 2
- access token HOT 2
- Issue upgrading package to 7.0 in laravel 10.48 HOT 3
- If fields are of type DateTime, their value should be null if they cannot be parsed HOT 1
- productFeesV0: getMyFeesEstimates: Can not parse the response HOT 1
- Interface throwing exception cannot be resolved HOT 1
- SQS Receive Messages Problem
- Quicker way to retrieve Amazon orders from SP API HOT 1
- Code Example for the Token Cache Implementation v7 HOT 2
- Look up sellerSku by fnSku? HOT 4
- The sample code in the README does not work, and the ->upload() helper seems to have issues under v7.1
- Parsing ProductTypes HOT 7
- Can Vendor Central utilize the Feed API? I'm encountering difficulties in creating a Feed Document. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from selling-partner-api.