GithubHelp home page GithubHelp logo

Never a PR Build about github-codebuild-logs HOT 5 OPEN

rehanvdm avatar rehanvdm commented on August 16, 2024
Never a PR Build

from github-codebuild-logs.

Comments (5)

rehanvdm avatar rehanvdm commented on August 16, 2024

Okay I figured it out, the Codebuild Github source was set to be triggered by PR_MERGE and PUSH. I could see Github send both events at the exact same time. It might be that the logic in the Codebuild receiver side somehow filters (or just wrong logic?) the PR_MERGE event out and then chooses the PUSH instead. After configuring only the PR_MERGE event as a source for the webhook did it start working.

@jlhood might be good to mention something like on the README?

from github-codebuild-logs.

rehanvdm avatar rehanvdm commented on August 16, 2024

Actually, I just spotted that I created the CodeBuild Source Github Event hook to trigger on HEAD_REF instead of BASE_REF, and that is why it never matched and most likely took my other trigger that said PUSH on HEAD_REF.

I think we can close, the AWS CodeXXX suite is not so friendly on documentation.

from github-codebuild-logs.

bracki avatar bracki commented on August 16, 2024

I have exactly the same problem. But I can't figure where exactly you changed the configuration? @rehanvdm did you do this in the web hook on the GitHub side?

from github-codebuild-logs.

rehanvdm avatar rehanvdm commented on August 16, 2024

@bracki No this is on the CodeBuild project, AWS side

from github-codebuild-logs.

bracki avatar bracki commented on August 16, 2024

Figured it out, my case is different. Because we are using batch builds, the actual builds will always have sourceVersion with a resolved version while the triggering build will still have pr/123.
To fix this we would need to check if buildBatchArn is set on a build and check the source version of that build instead.

from github-codebuild-logs.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.