GithubHelp home page GithubHelp logo

Should print URL when booting about serve HOT 12 CLOSED

topfunky avatar topfunky commented on September 17, 2024
Should print URL when booting

from serve.

Comments (12)

ntalbott avatar ntalbott commented on September 17, 2024

How did I not know about clickable terminal urls? This changes everything.

from serve.

jlong avatar jlong commented on September 17, 2024

I like this idea. A pull request would be welcome.

from serve.

wazery avatar wazery commented on September 17, 2024

I think their is no need for a PR, I can open the link on with my OS X Terminal with these shortcuts:

Before OS X Lion:

cmd+shift+double-click on a URL in Terminal.app and it will open in the default browser.

OS X >= Lion:

cmd+double-click (otherwise you will enter fullscreen mode).

Hope these help!

from serve.

topfunky avatar topfunky commented on September 17, 2024

@wazery I believe the issue was that serve originally did not print any URL at all, so there was nothing that could be single clicked, double clicked, cmd+shift+triple-clicked with your right foot in and your right foot out, or any other way.

from serve.

wazery avatar wazery commented on September 17, 2024

Good that they added URLs, so this issue can be closed now, right?

from serve.

topfunky avatar topfunky commented on September 17, 2024

I just tried with 1.5.2 and there's still no URL.

Install Mongrel or Thin for better performance.
[2015-04-02 18:28:36] INFO  WEBrick 1.3.1
[2015-04-02 18:28:36] INFO  ruby 2.0.0 (2014-05-08) [universal.x86_64-darwin13]
[2015-04-02 18:28:36] INFO  WEBrick::HTTPServer#start: pid=60526 port=4000
^C[2015-04-02 18:29:08] INFO  going to shutdown ...
[2015-04-02 18:29:08] INFO  WEBrick::HTTPServer#start done.

from serve.

wazery avatar wazery commented on September 17, 2024

Oh, then I will create a PR and reference this issue.

from serve.

wazery avatar wazery commented on September 17, 2024

After reading into lib/serve/application.rb, I found both #277 and #284 lines are printing the URL for only Thin or Mongrel servers. From your log apparently you are using WEBrick, so I am thinking of adding a URL to it also, @jlong WDYT?

from serve.

jlong avatar jlong commented on September 17, 2024

Merged! Thank you! This will be in the next release.

from serve.

wazery avatar wazery commented on September 17, 2024

Cool, thanks.

from serve.

jlong avatar jlong commented on September 17, 2024

Also made you a colaborator. If there is anything else you'd like to tidy up, please do!

from serve.

wazery avatar wazery commented on September 17, 2024

Awesome, thanks for that, I will investigate in the issues and contribute more 😃

from serve.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.