Table isn't sortable, throws Uncaught ReferenceError: gData is not defined about hack-spots

[jlord]

Ah, that's bad. I'm afraid this whole thing should be re-written, I get really terrified when I look at it now 😳

I think that's a fine fix for this right now, if you want to do a PR that would be ✨

[deltamualpha]

OK! I'll see what I can do (my main branch has diverged far enough that I can't just pull out the commit, I think).

Heck, this might be a fun project to learn me some proper JS and try a cleanup/modernization pull request...

[jlord]

So I actually just put in the latest version and sheetsee.js (this project had a really old version) and it solved the issue you were having. I'm going to go ahead and push it, but there is still lots of clean up that could be done!

[jlord]

Ok, I spoke too soon :) I ended up breaking more things than I fixed, so let's go with your way for now!

[deltamualpha]

Pull request done for that small change.

I'm seeing what you meant by the difficulty in upgrading sheetsee! I'm currently fighting with iCanHaz not having the templates available within the table() function... it's mystifying.

Update: initial work here: https://github.com/nyc-bookstores/nyc-bookstores.github.io/tree/sheetsee-upgrade. Getting strange errors when clicking on items on the map, and the popups don't render anymore. Also, I found a bug in sheetsee-table (the if-else logic on non-paginated tables is busted, causing it to render the table twice, the second time with no data, resulting in an empty table.)

[deltamualpha]

For the makeTable() bug, compare https://github.com/jlord/sheetsee.js/blob/master/js/sheetsee.js#L25273-L25282 with https://github.com/nyc-bookstores/nyc-bookstores.github.io/blob/62d257957b73d42bd008ca89d66035f22bcc74b5/js/sheetsee.js#L16171-L16182