GithubHelp home page GithubHelp logo

Comments (3)

jmg-duarte avatar jmg-duarte commented on June 3, 2024

Hello, I'm glad you reported this issue! Could you provide the cargo expand output?

from sealed-rs.

jmg-duarte avatar jmg-duarte commented on June 3, 2024

@WilliamVenner I have a fix for your issue in particular but I'd like a better example to solidify the implementation.
If you could submit one, it would be great!

from sealed-rs.

MingweiSamuel avatar MingweiSamuel commented on June 3, 2024

The issue is that here only type_params are forwarded, not lifetimes or const generic params:

sealed-rs/src/lib.rs

Lines 157 to 159 in aea9c3d

item_trait
.supertraits
.push(parse_quote!( #seal::Sealed <#(#type_params, )*> ));

The fix (#13) is to use let (_, ty_generics, _) = trait_generics.split_for_impl(); and #seal::Sealed #ty_generics which includes all three types of params together.

from sealed-rs.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.