Comments (5)
A bit of investigation has narrowed my focus to concat(x,y)'s handling when x
or y has canEmpty=true and a prefix/suffix list rather than a list of exact
matches. The hunt continues...
Original comment by dgryski
on 5 Mar 2012 at 6:29
from codesearch.
I'm stumped. I think this bug is beyond my current familiarity with the
codebase. I'm certain the issue is with concat(), but after many hours of
staring at this I really have no idea what the fix should look like.
Original comment by dgryski
on 6 Mar 2012 at 8:40
from codesearch.
So, it looks like this particular issue is actually in alternate(). The code
assumes that either x and y are both exact or both have prefix/suffix lists.
This obviously isn't the case.
The above bug is caused by the fact that emptyString() has an exact match but
no prefix/suffix lists, so when being combined we were unioning with a nil
list. This didn't crash, it just didn't have the expected behaviour.
This also fixes the case where, when searching for '(123|4567)q' , we would get
"67q" as the only required trigram, instead of the correct ("23q"|"67q").
Original comment by dgryski
on 7 Mar 2012 at 9:37
Attachments:
from codesearch.
After writing that last sentence, I realized that my "corrected" trigrams were
still missing some. My implementation of alternate ignored the exact matches.
We now call addExact() before combining the matches. This allows the (this
time for sure ;) correct trigram set:
("123")|("456" "567") ("23q"|"67q")
to be generated.
Original comment by dgryski
on 7 Mar 2012 at 11:07
Attachments:
from codesearch.
This issue was closed by revision 56b76ffbf8bb.
Original comment by dgryski
on 2 May 2012 at 8:26
- Changed state: Fixed
from codesearch.
Related Issues (20)
- Line missing in read.go HOT 3
- csearch: Add flag (-g) for grouping output by file (a'la ack --group, or git grep --heading) [PATCH] HOT 4
- Error in read.go comments
- go install fails to find package
- Option to remove a path from index
- Pull request: add support for per-file custom annotations
- "csearch -n" output is 0-based, not 1-based HOT 1
- Files containing ascii8 are not indexed (feature/request) HOT 4
- IndexWriter always writes logs
- How can I tell cindex to ignore certain folders? (such as logs/, *.log, tmp/ etc.) HOT 3
- cindex fails with mmap errors on OpenBSD HOT 1
- Cannot index / search one file HOT 8
- mmap_windows.go not updated for latest go version
- .csearchindex is world-readable HOT 1
- cindex needs vast amounts of temporary space HOT 1
- Windows missing conversion HOT 1
- fix bug in siftUp() HOT 3
- Patch for /index/write_test.go HOT 1
- cindex ignores IRC log files HOT 3
- Minor adjustment of Csearch page. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codesearch.