Comments (5)
FYI: anyone trying to dupe this issue who doesn't have yarn installed, make sure you install it via npm, not apt, as the yarn from apt in cmdtest isn't the same program.
I managed to dupe the issue on Ubuntu 16.04.02 and 17.04, but oddly yarn list
doesn't show uglify-js anywhere, even under jade-legacy despite that it's in that package's package.json. My guess is that this is actually an issue with yarn, or at the very least a question for the yarn devs--maybe there's a reason it doesn't install uglify-js? On a quick inspection I couldn't find another package in the deps that didn't get installed, but that probably needs a more thorough check.
Updating to pug may fix it, but I'm only part sure because I merely replaced the node_modules/wintersmith packaged with a checkout of the pug-migrate branch and ran yarn in it to try and duplicate yarn's steps. What's weird is that doing this with the main wintersmith package doesn't result in uglify appearing in node_modules. Also odd is that jade-legacy specifies a newer version of uglify than pug. In pug, uglify appears as a requirement of its components. This still doesn't explain why yarn installs uglify for pug and not for jade-legacy.
Two notes: manually adding uglify in the mainline wintersmith package:
//after cloning and running yarn
cd node_modules/wintersmith
yarn add uglify-js
//return to repo root
cd ../../
Then returning to the repo root and running yarn build
worked, except that the two consts in templates/fragen.jade in table#questionstable
, capitalize and formatedCategories, threw errors as they are previously declared on the first run of the loop; I changed them to vars and everything worked.)
I still suspect this is a good question for the yarn people; it's odd that it doesn't install uglify-js for jade-legacy.
EDIT: also note that, if you do use the pug update, you'll have to rename a number of files and change the template arguments in their meta.
from wintersmith.
Root cause looks to be that jade-legacy
fails because it can't find uglify-js
. No idea why, it's listed in package.json https://github.com/jnordberg/jade-legacy/blob/master/package.json#L33
from wintersmith.
Maybe that would be fixed by #325 :)
from wintersmith.
Any update on this?
from wintersmith.
I'm unable to reproduce with yarn 1.5.1. Is this still a problem?
from wintersmith.
Related Issues (20)
- Feature Request: Adding custom markdown tags HOT 2
- Use plain HTML content instead of Markdown? HOT 2
- Beta release with Pug v2 support HOT 6
- Is wintesmith support on Windows? HOT 3
- Sitemap HOT 1
- Generating website with javascript HOT 1
- Website links in markdown containing numbers are not being parsed correctly HOT 2
- npm issues deprecated warning when installing wintersmith HOT 1
- No mention of AMP support
- update help output to reflect that some options cannot be set in the config file
- Wintersmith preview/build fails when upgrading from 2.4.1 to 2.5.0 HOT 1
- marked upgrade from 0.3.x to 0.5.x changed how markdown inside html is parsed HOT 1
- Error loading plugin './node_modules/wintersmith-sassify': Module did not self-register.
- marked must be >=0.6.1else github displays security error
- Any way to use chrome devtools for debugging purposes? HOT 1
- upgrade highlight.js to version 10
- [Question] Does Wintersmith support multi-languages ?
- Asset hashes or versioning
- [Question/Bug?] Archives shows '404 Not Found' after I changed config "baseUrl" HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wintersmith.