GithubHelp home page GithubHelp logo

Comments (7)

sbourdeauducq avatar sbourdeauducq commented on July 29, 2024

either skip or fix segfault in tests.

Why would skipping be a good idea at all?

from py-lmdb.

thomasfire avatar thomasfire commented on July 29, 2024

Why would skipping be a good idea at all?

If the temporary files are not supported by mingw for example (I am not sure though, it looks like it would work fine with MSVC), then probably it would be better to skip and mark as not supported features

from py-lmdb.

sbourdeauducq avatar sbourdeauducq commented on July 29, 2024

Why would temporary files not being supported cause a segfault?

from py-lmdb.

thomasfire avatar thomasfire commented on July 29, 2024

Well the true issue appears to be in these lines:
https://github.com/LMDB/lmdb/blob/3947014aed7ffe39a79991fa7fb5b234da47ad1a/libraries/liblmdb/mdb.c#L1737-L1745
The same code is in this repo.
Looks like I'll need to change C API a bit to handle these strings properly

from py-lmdb.

sbourdeauducq avatar sbourdeauducq commented on July 29, 2024

Haha this is such garbage code. Can you just do something like static char buf[MSGSIZE]? It's not thread-safe, but I'm not sure if the current code is any better...

from py-lmdb.

sbourdeauducq avatar sbourdeauducq commented on July 29, 2024

And Python doesn't have real threads due to the GIL so it probably doesn't matter here.

from py-lmdb.

thomasfire avatar thomasfire commented on July 29, 2024

Updated patch with segfault fix: msys2/MINGW-packages#17095

from py-lmdb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.