Comments (13)
Done, and tagging a new release. Thanks!
from drupal-core-development-project.
Should something like exec: corepack enable
be in DDEV's own project templates? That seems like quite fiddly steps.
from drupal-core-development-project.
That's there for pre-DDEV v1.23.0.
from drupal-core-development-project.
I see v1.23.0 is still in alpha.
I'd rather not give people complex instructions that are probably not necessary. So, either:
- hold off this PR until v1.23.0 is released and say in the docs that's the minimum recommended version
- change the PR now to say that bit is only for pre-v1.23.0.
from drupal-core-development-project.
OTOH @rpkoller pays careful attention to things and would surely do another PR at v1.23.0 release :)
from drupal-core-development-project.
i've pushed a few changes to the installation on ddev
section adjusting to the changes in the soon to be released version 1.23.0 of ddev. and i've added a disclaimer that the user has to make sure that ddev is upgraded to 1.23.0 before applying the next steps. but at the moment the composer require will fail in any case since drush is incompatible with symfony 7 in drupal 11.
from drupal-core-development-project.
Urgh, I didn't know about the Drush / Symfony 7 problem. Thanks for the heads up!
Is your PR ready for merge?
from drupal-core-development-project.
I would still prefer to run through an entire test setup with the new instructions. I think it should be good to go and working, but I just want to make sure (the combination of the new drupal project type, drupal 11 and a composer create based install is tricky). With DDEV 1.23.0 being released about five hours ago https://github.com/ddev/ddev/releases/tag/v1.23.0 and with the last real blocker being off the list https://drupal.slack.com/archives/C62H9CWQM/p1713323431321799?thread_ts=1712073362.477139&cid=C62H9CWQM it it sounds like a Drupal 11 ready release for Drush is close as well. I keep an constant eye on when Drush is ready and would test the instructions in this PR a final time and give you a heads up then here.
from drupal-core-development-project.
Ok, great!
from drupal-core-development-project.
Drush 13 is supporting Drupal 11 now: https://drupal.slack.com/archives/C62H9CWQM/p1713402423437749?thread_ts=1712073362.477139&cid=C62H9CWQM
but i think the composer.json would have to be updated, changing from ^12
to 13.x
, then it would be possible to test the steps in this PR.
from drupal-core-development-project.
oh just noticed you have updated the composer.json to ^13
. so i've quickly manually tested #27 and can confirm that the steps are correct as i've assumed and the setup is running through properly.
from drupal-core-development-project.
Ok. Is it ready to merge?
from drupal-core-development-project.
yes
from drupal-core-development-project.
Related Issues (15)
- Error messages when running composer install, after switching from Drupal core 9.2.x to 9.1.x HOT 10
- Dependency conflicts of Drupal core 8.9.x and var-dumper:^5.1 HOT 3
- Add ability to easily check Drupal coding standards HOT 1
- DRUPAL_ROOT value is the symlinked directory, instead of the project location HOT 2
- ComposerProjectTemplatesTest.php doesn't work HOT 7
- Project does not work with core's 10.0.x branch HOT 2
- Contrib tests can not be executed HOT 6
- [drush] Uncaught Exception: Could not locate autoload.php when `vendor/` folder is symlinked HOT 5
- Update dependencies for Drupal 10 HOT 3
- DevelopmentProjectCommands Class conflicts for Drush 12 HOT 2
- Fix installation profiles and libraries not working
- Install command results in error HOT 10
- contrib modules can't be installed by Composer if core is on 11.x branch HOT 1
- DevelopmentProjectCommands broken on Drush 12 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drupal-core-development-project.