GithubHelp home page GithubHelp logo

Comments (9)

jodastephen avatar jodastephen commented on May 27, 2024

I don't see why that is a problem - its just normal Maven behaviour. That file is the pom.xml as seen in the project. If maven interprets it, the variables will be resolved.

from joda-convert.

sormuras avatar sormuras commented on May 27, 2024

True.

But if you grab the value as-is you no longer get the final expanded value.

Version 1.9.2 of the pom.xml declared <url>http://www.joda.org/joda-convert/</url> ... which is directly useable from scanners like jpms-module-names ... which don't use "normal" Maven/Aether API to retrieve values from the poms.

from joda-convert.

jodastephen avatar jodastephen commented on May 27, 2024

Unfortunately this is just the way Maven works. See here for example

from joda-convert.

sormuras avatar sormuras commented on May 27, 2024

Sure. But ${...} is seldom used in the URL element. Older versions of your libraries don't do it. All other libraries included in the jpms-module-names table don't do it.

This is 100% an issue of the jpms-module-names parser/generator -- thus, I'm closing this and JodaOrg/joda-beans#189

from joda-convert.

jodastephen avatar jodastephen commented on May 27, 2024

I'm introducing a parent pom, so all joda-projects will likely have this over time!

from joda-convert.

sormuras avatar sormuras commented on May 27, 2024

I saw it coming... 🙈

from joda-convert.

sormuras avatar sormuras commented on May 27, 2024

...maybe, I'll enhance the XML/POM parser to look for local properties:

<properties>
<!--  Parent pom.xml control  -->
<joda.osgi.packages>org.joda.convert.*</joda.osgi.packages>
<joda.module.name>org.joda.convert</joda.module.name>
<joda.artifactId>joda-convert</joda.artifactId>
<!--  Set to Java 6  -->
<joda.release.version>6</joda.release.version>
<maven.compiler.compilerVersion>1.6</maven.compiler.compilerVersion>
<maven.compiler.source>1.6</maven.compiler.source>
<maven.compiler.target>1.6</maven.compiler.target>
</properties>

from joda-convert.

sormuras avatar sormuras commented on May 27, 2024

Done in jodastephen/jpms-module-names@692be4f

from joda-convert.

jodastephen avatar jodastephen commented on May 27, 2024

Great!

from joda-convert.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.