[Android] Update doc for compatibity with RN 0.30+ about react-native-linkedin-login

[jodybrewster]

@mlumbroso Yes soon! Finally I have some time! weeeeeee

[mlumbroso]

I think I made it work, will update tomorrow with what I did at the end :-)

[jodybrewster]

I moved everything to cocoapods so you may want to pull

[assem-ch]

is this issue fixed ?

[luisfuertes]

This component works on Android and iOS with RN v0.33.0?

[mlumbroso]

On 0.32 it does (you need to try to put parts of MainActivity in MainApplication.java for Android, don't remember exactly I'll try to clarify this), so I don't think there should be any issue with 0.33

[Tohix]

Can you please update doc for RN 0.35? If you have already build application with new version RN, please help.

[luisfuertes]

Im trying to implement the component on Project with RN v0.33.0.
At the moment:

android/app/build.gradle:

include ':react-native-linkedin-login'
project(':react-native-linkedin-login').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-linkedin-login/android')

include ':react-native-vector-icons'
project(':react-native-vector-icons').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-vector-icons/android')

android/build.gradle:

    compile project(":react-native-linkedin-login")
    compile project(':react-native-vector-icons')

MainAplication:

import net.jodybrewster.linkedinlogin.RNLinkedinLoginModule;
import net.jodybrewster.linkedinlogin.RNLinkedinLoginPackage;
import com.oblador.vectoricons.VectorIconsPackage;

    @Override
    protected List<ReactPackage> getPackages() {
      return Arrays.<ReactPackage>asList(
          new MainReactPackage(),
          new VectorIconsPackage(),
          new RNLinkedinLoginPackage()
      );
    }

MainActivity:

import com.linkedin.platform.LISessionManager;

    @Override
    public void onActivityResult(int requestCode, int resultCode, Intent data) {
        LISessionManager.getInstance(getApplicationContext()).onActivityResult(requestCode, resultCode, data);
        super.onActivityResult(requestCode, resultCode, data);
        MainApplication.getCallbackManager().onActivityResult(requestCode, resultCode, data);
    }

On /node_modules/react-native-linkedin-login/android/src/main/java/net/jodybrewster/RNLinkedinLoginPackage.java delete this function:

    public RNLinkedinLoginPackage(Activity activity) {
        super();
        _activity = activity;
    }

And app compile, but when i press Linkedin login button:
Attemp t invoke virtual method 'void android.app.Activity.runOnUiThread(java.lang.Runnable)' on a null object reference on RNLinkedinLoginModule.java line 191.

EDIT: I have problems to implement this component on iOS too. I will wait to @jodybrewster update the component

[gorgekara]

I'm having the same issue implementing this on Android as well - can you please update the docs for React Native > 0.35

Followed @luisfuertes steps but got different error:

MainApplication.java:46: error: constructor RNLinkedinLoginPackage in class RNLinkedinLoginPackage cannot be applied to given types;
   new RNLinkedinLoginPackage()
   ^

UPDATE:
This fork seems to have a fix for React Native > 0.35 issue (uses getCurrentActivity): https://github.com/alma-connect/react-native-linkedin-login

Made it work with:

/android/settings.gradle

include ':react-native-linkedin-login'
project(':react-native-linkedin-login').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-linkedin-login/android')

/android/app/build.gradle

dependencies {
    ...
    compile fileTree(dir: "libs", include: ["*.jar"])
    compile "com.android.support:appcompat-v7:23.0.1"
    compile "com.facebook.react:react-native:+"
    compile project(":react-native-linkedin-login") // <-- add this one
}

/android/app/.../MainActivity.java

import com.linkedin.platform.LISessionManager; // <-- add this one

(...)

@Override
public void onActivityResult(int requestCode, int resultCode, Intent data) {
        LISessionManager.getInstance(getApplicationContext()).onActivityResult(this, requestCode, resultCode, data); // <-- add this one

        super.onActivityResult(requestCode, resultCode, data);
        MainApplication.getCallbackManager().onActivityResult(requestCode, resultCode, data);
}

/android/.../MainApplicaiton.java

import net.jodybrewster.linkedinlogin.RNLinkedinLoginModule; // <-- add this one
import net.jodybrewster.linkedinlogin.RNLinkedinLoginPackage; // <-- add this one

(...)

@Override
protected List<ReactPackage> getPackages() {
      return Arrays.<ReactPackage>asList(
        new MainReactPackage(),
        new RNGoogleSigninPackage(),
        new ReactNativeOneSignalPackage(),
        new RNLinkedinLoginPackage(), // <-- add this one here
        new FBSDKPackage(mCallbackManager)
      );
}

IMPORTANT
Make sure to generate hash as described here: http://stackoverflow.com/questions/29787977/android-linkedin-mobile-sdk-error and add it in your LinkedIn Developer Settings > Mobile under Package Name & Package Hash.

NOTE
At the time i'm testing this the LinkedIn API is bit buggy (UNKNOWN ERROR is returned in some cases even though i have everything setup properly).

Please ping me if i'm doing something wrong.